From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH 05/13] libxl: remove unsigned less-than-0 comparison Date: Sun, 1 Dec 2013 23:14:59 +1300 Message-ID: <1385892907-20084-6-git-send-email-mattd@bugfuzz.com> References: <1385892907-20084-1-git-send-email-mattd@bugfuzz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385892907-20084-1-git-send-email-mattd@bugfuzz.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Matthew Daley , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org ...from libxl_cpuid_parse_config_xend. value is unsigned so this doesn't work, and either way the following comparison on it being bigger than 3 does what was intended here anyway. Coverity-ID: 1055614 Signed-off-by: Matthew Daley --- tools/libxl/libxl_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_cpuid.c b/tools/libxl/libxl_cpuid.c index e1c406c..dd21b78 100644 --- a/tools/libxl/libxl_cpuid.c +++ b/tools/libxl/libxl_cpuid.c @@ -298,7 +298,7 @@ int libxl_cpuid_parse_config_xend(libxl_cpuid_policy_list *cpuid, } value = str[1] - 'a'; endptr = strchr(str, '='); - if (value < 0 || value > 3 || endptr == NULL) { + if (value > 3 || endptr == NULL) { return 4; } str = endptr + 1; -- 1.7.10.4