From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Kiper Subject: [PATCH] libxenctrl: Fix xc_interface_close() crash if it gets NULL as an argument Date: Mon, 2 Dec 2013 20:13:03 +0100 Message-ID: <1386011583-29413-1-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: ian.campbell@citrix.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org Cc: Daniel Kiper List-Id: xen-devel@lists.xenproject.org xc_interface_close() crashes if it gets NULL as an argument. However, it just calls xc_interface_close_common() which is called by many others functions. It means that they are also vulnerable. So fix above mentioned issue by adding NULL check in xc_interface_close_common(). This way we fix similar issue in other functions which calls xc_interface_close_common() too. Signed-off-by: Daniel Kiper --- tools/libxc/xc_private.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/libxc/xc_private.c b/tools/libxc/xc_private.c index 524862e..838fd21 100644 --- a/tools/libxc/xc_private.c +++ b/tools/libxc/xc_private.c @@ -198,6 +198,9 @@ static int xc_interface_close_common(xc_interface *xch) { int rc = 0; + if (!xch) + return 0; + xc__hypercall_buffer_cache_release(xch); xtl_logger_destroy(xch->dombuild_logger_tofree); -- 1.7.10.4