From: Daniel Kiper <daniel.kiper@oracle.com>
To: jbeulich@suse.com, keir@xen.org, xen-devel@lists.xen.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH] xen/arch/x86: Fix early boot command line parsing
Date: Mon, 2 Dec 2013 20:15:20 +0100 [thread overview]
Message-ID: <1386011720-29451-1-git-send-email-daniel.kiper@oracle.com> (raw)
There is no reliable way to encode nul character as a character so encode
it as a number. Read: http://sourceware.org/binutils/docs/as/Characters.html.
Octal and hex encoding does not work on at least my system (GNU assembler
version 2.22 (x86_64-linux-gnu) using BFD version (GNU Binutils for Debian) 2.22).
Without this fix e.g. no-real-mode option at the end of xen.gz command line
is not detected. Additionally, encode other characters accordingly to
the gas documentation.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
xen/arch/x86/boot/cmdline.S | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/xen/arch/x86/boot/cmdline.S b/xen/arch/x86/boot/cmdline.S
index 05ffb94..4ea56b3 100644
--- a/xen/arch/x86/boot/cmdline.S
+++ b/xen/arch/x86/boot/cmdline.S
@@ -138,11 +138,11 @@
call .Lstrlen
add $4,%esp
xadd %eax,%ebx
- cmpb $'\0',(%ebx)
+ cmpb $0,(%ebx)
je 3f
- cmpb $' ',(%ebx)
+ cmpb $' ,(%ebx)
je 3f
- cmpb $'=',(%ebx)
+ cmpb $'=,(%ebx)
jne 1b
3: pop %ebx
ret
--
1.7.10.4
next reply other threads:[~2013-12-02 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 19:15 Daniel Kiper [this message]
2013-12-03 2:14 ` [PATCH] xen/arch/x86: Fix early boot command line parsing Andrew Cooper
2013-12-03 10:34 ` Jan Beulich
2013-12-03 10:47 ` Andrew Cooper
2013-12-03 10:59 ` Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386011720-29451-1-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).