From: Bob Liu <lliubbo@gmail.com>
To: xen-devel@lists.xenproject.org
Cc: keir@xen.org, ian.campbell@citrix.com, JBeulich@suse.com
Subject: [PATCH v2 04/16] tmem: cleanup: drop useless function 'tmem_copy_page'
Date: Tue, 3 Dec 2013 10:19:05 +0800 [thread overview]
Message-ID: <1386037157-27261-5-git-send-email-bob.liu@oracle.com> (raw)
In-Reply-To: <1386037157-27261-1-git-send-email-bob.liu@oracle.com>
Use memcpy directly.
Signed-off-by: Bob Liu <bob.liu@oracle.com>
---
xen/common/tmem_xen.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/xen/common/tmem_xen.c b/xen/common/tmem_xen.c
index 1e002ae..af67703 100644
--- a/xen/common/tmem_xen.c
+++ b/xen/common/tmem_xen.c
@@ -44,11 +44,6 @@ static DEFINE_PER_CPU_READ_MOSTLY(unsigned char *, workmem);
static DEFINE_PER_CPU_READ_MOSTLY(unsigned char *, dstmem);
static DEFINE_PER_CPU_READ_MOSTLY(void *, scratch_page);
-void tmem_copy_page(char *to, char*from)
-{
- memcpy(to, from, PAGE_SIZE);
-}
-
#if defined(CONFIG_ARM)
static inline void *cli_get_page(xen_pfn_t cmfn, unsigned long *pcli_mfn,
struct page_info **pcli_pfp, bool_t cli_write)
@@ -135,7 +130,7 @@ EXPORT int tmem_copy_from_client(struct page_info *pfp,
}
smp_mb();
if ( len == PAGE_SIZE && !tmem_offset && !pfn_offset && cli_va )
- tmem_copy_page(tmem_va, cli_va);
+ memcpy(tmem_va, cli_va, PAGE_SIZE);
else if ( (tmem_offset+len <= PAGE_SIZE) &&
(pfn_offset+len <= PAGE_SIZE) )
{
@@ -206,7 +201,7 @@ EXPORT int tmem_copy_to_client(xen_pfn_t cmfn, struct page_info *pfp,
tmem_mfn = page_to_mfn(pfp);
tmem_va = map_domain_page(tmem_mfn);
if ( len == PAGE_SIZE && !tmem_offset && !pfn_offset && cli_va )
- tmem_copy_page(cli_va, tmem_va);
+ memcpy(cli_va, tmem_va, PAGE_SIZE);
else if ( (tmem_offset+len <= PAGE_SIZE) && (pfn_offset+len <= PAGE_SIZE) )
{
if ( cli_va )
--
1.7.10.4
next prev parent reply other threads:[~2013-12-03 2:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 2:19 [PATCH v2 00/16] tmem: continue to cleanup tmem Bob Liu
2013-12-03 2:19 ` [PATCH v2 01/16] tmem: fix public head file Bob Liu
2013-12-06 10:03 ` Jan Beulich
2013-12-06 14:36 ` Konrad Rzeszutek Wilk
2013-12-03 2:19 ` [PATCH v2 02/16] tmem: cleanup: drop unused sub command Bob Liu
2013-12-03 2:19 ` [PATCH v2 03/16] tmem: cleanup: drop some debug code Bob Liu
2013-12-03 2:19 ` Bob Liu [this message]
2013-12-03 2:19 ` [PATCH v2 05/16] tmem: cleanup: drop useless parameters from put/get page Bob Liu
2013-12-03 2:19 ` [PATCH v2 06/16] tmem: cleanup: reorg function do_tmem_put() Bob Liu
2013-12-03 2:19 ` [PATCH v2 07/16] tmem: drop unneeded is_ephemeral() and is_private() Bob Liu
2013-12-03 2:19 ` [PATCH v2 08/16] tmem: cleanup: rm useless EXPORT/FORWARD define Bob Liu
2013-12-03 2:19 ` [PATCH v2 09/16] tmem: cleanup: drop runtime statistics Bob Liu
2013-12-03 2:19 ` [PATCH v2 10/16] tmem: cleanup: drop tmem_lock_all Bob Liu
2013-12-03 2:19 ` [PATCH v2 11/16] tmem: cleanup: refactor the alloc/free path Bob Liu
2013-12-03 2:19 ` [PATCH v2 12/16] tmem: cleanup: __tmem_alloc_page: drop unneed parameters Bob Liu
2013-12-03 2:19 ` [PATCH v2 13/16] tmem: cleanup: drop useless functions from head file Bob Liu
2013-12-03 10:32 ` Andrew Cooper
2013-12-06 6:53 ` Bob Liu
2013-12-03 2:19 ` [PATCH v2 14/16] tmem: refator function tmem_ensure_avail_pages() Bob Liu
2013-12-03 2:19 ` [PATCH v2 15/16] tmem: cleanup: rename tmem_relinquish_npages() Bob Liu
2013-12-03 2:19 ` [PATCH v2 16/16] tmem: cleanup: rm unused tmem_freeze_all() Bob Liu
2013-12-03 21:07 ` [PATCH v2 00/16] tmem: continue to cleanup tmem Konrad Rzeszutek Wilk
2013-12-03 21:50 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386037157-27261-5-git-send-email-bob.liu@oracle.com \
--to=lliubbo@gmail.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).