From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v5 12/17] xen/libxc: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity Date: Tue, 3 Dec 2013 12:30:19 +0100 Message-ID: <1386070219.5338.293.camel@Solace> References: <20131202180129.29026.81543.stgit@Solace> <20131202182908.29026.23720.stgit@Solace> <529DBA3F02000078001093CF@nat28.tlf.novell.com> <1386068388.5338.270.camel@Solace> <529DCC75020000780010952A@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2422411120200488033==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VnoBP-0002fP-1T for xen-devel@lists.xenproject.org; Tue, 03 Dec 2013 11:30:27 +0000 In-Reply-To: <529DCC75020000780010952A@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Marcus Granado , Justin Weaver , Ian Campbell , Li Yechen , George Dunlap , AndrewCooper , Juergen Gross , Ian Jackson , MattWilson , xen-devel , KeirFraser , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============2422411120200488033== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-2I3pW9YY1teH3wsQo5d3" --=-2I3pW9YY1teH3wsQo5d3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-12-03 at 11:20 +0000, Jan Beulich wrote: > >>> On 03.12.13 at 11:59, Dario Faggioli wrot= e: > > Well, actually, I only asked what we should be returning from > > DOMCTL_vcpu_setaffinity, and never mentioned DOMCTL_vcpu_getaffinity > > because I seriously thought there was no need to discuss what the latte= r > > should be returning, and whether or not the two return values should > > match. >=20 > And I would also have doubted that I ever said to do something > intentionally inconsistent... >=20 Well, if you ask me, you never did, as I think this is perfectly consistent. :-) > > That being said, I of course can say something about this in some > > docs/header. Actually, the following patch does that quite thoroughly, = I > > think, in tools/libxc/xenctrl.h. I can certainly add something similar > > in Xen's public .h files. >=20 > As said - as long as there is proper reasoning and at least a brief > explanation in the public header (xenctrl.h not being considered > "public" in the context here"), I'm fine with the returned masks > differing. >=20 Ok, as I anticipated, I'll make a note about this in an hypervisor public header. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-2I3pW9YY1teH3wsQo5d3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKdwMsACgkQk4XaBE3IOsQkkACeJ0owKJhox6P/V4st1ZG1nr3L HCgAnj7tY8xS7MXGB4QIH9ul2sLfVQkq =2L96 -----END PGP SIGNATURE----- --=-2I3pW9YY1teH3wsQo5d3-- --===============2422411120200488033== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2422411120200488033==--