From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v5 12/17] xen/libxc: sched: DOMCTL_*vcpuaffinity works with hard and soft affinity Date: Tue, 3 Dec 2013 14:25:33 +0100 Message-ID: <1386077133.5338.326.camel@Solace> References: <20131202180129.29026.81543.stgit@Solace> <20131202182908.29026.23720.stgit@Solace> <529DBA3F02000078001093CF@nat28.tlf.novell.com> <529DBB4A02000078001093E5@nat28.tlf.novell.com> <1386068881.5338.276.camel@Solace> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3755445275849630140==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Vnpyv-0000x1-Bk for xen-devel@lists.xenproject.org; Tue, 03 Dec 2013 13:25:41 +0000 In-Reply-To: <1386068881.5338.276.camel@Solace> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Marcus Granado , Justin Weaver , Ian Campbell , Li Yechen , George Dunlap , Andrew Cooper , Juergen Gross , Ian Jackson , Matt Wilson , xen-devel , Keir Fraser , Elena Ufimtseva List-Id: xen-devel@lists.xenproject.org --===============3755445275849630140== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-jAWUJfKZBPjOqjohlVjE" --=-jAWUJfKZBPjOqjohlVjE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mar, 2013-12-03 at 12:08 +0100, Dario Faggioli wrote: > On mar, 2013-12-03 at 10:06 +0000, Jan Beulich wrote: > > And just to make it explicit - with fundamental flaws like this, I'm > > not certain anymore whether we really ought to rush this series > > in for 4.4. > >=20 > Well, I certainly have no intention to say that this isn't something > that I overlooked. Just for the sake of completeness, that's what's > required to fix it: >=20 > diff --git a/xen/common/domctl.c b/xen/common/domctl.c > index 9eecb5e..cd817f3 100644 > --- a/xen/common/domctl.c > +++ b/xen/common/domctl.c > @@ -661,7 +661,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u= _domctl) > { > ret =3D xenctl_bitmap_to_bitmap(cpumask_bits(new_affinit= y), > &vcpuaff->cpumap_hard, > - vcpuaff->cpumap_hard.nr_bi= ts); > + nr_cpu_ids); > if ( !ret ) > ret =3D vcpu_set_hard_affinity(v, new_affinity); > if ( ret ) > @@ -679,7 +679,7 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u= _domctl) > { > ret =3D xenctl_bitmap_to_bitmap(cpumask_bits(new_affinit= y), > &vcpuaff->cpumap_soft, > - vcpuaff->cpumap_soft.nr_bi= ts); > + nr_cpu_ids); > if ( !ret) > ret =3D vcpu_set_soft_affinity(v, new_affinity); > if ( ret ) >=20 BTW, there's a v6 with this fixed, as well as other Jan's (coding style and explaining interface in public headers) and IanC's (about code motion) comments addressed: git://xenbits.xen.org/people/dariof/xen.git numa/per-vcpu-affinity-v6 http://xenbits.xen.org/gitweb/?p=3Dpeople/dariof/xen.git;a=3Dshortlog;h=3D= refs/heads/numa/per-vcpu-affinity-v6 Just waiting a bit more to post it, to see if there are other comments. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-jAWUJfKZBPjOqjohlVjE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKd280ACgkQk4XaBE3IOsRlcACfcopNEc0MrY8PRXverQXqQCCM bMsAn3LJzSYyARTu5W4vyp34hFnt0gP3 =7++e -----END PGP SIGNATURE----- --=-jAWUJfKZBPjOqjohlVjE-- --===============3755445275849630140== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3755445275849630140==--