From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH] xen_disk: fix memory leak Date: Wed, 4 Dec 2013 15:16:18 +1300 Message-ID: <1386123378-12699-1-git-send-email-mattd@bugfuzz.com> References: <1386069032.13256.10.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1386069032.13256.10.camel@kazak.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: ilon@medinet.se, Ian Campbell , Stefano Stabellini , Matthew Daley , Ian Jackson , Niklas Bivald , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org T24gaW9yZXFfcmVsZWFzZSB0aGUgZnVsbCBpb3JlcSB3YXMgbWVtc2V0IHRvIDAsIGxvb3Npbmcg YWxsIHRoZSBkYXRhCmFuZCBtZW1vcnkgYWxsb2NhdGlvbnMgaW5zaWRlIHRoZSBRRU1VSU9WZWN0 b3IsIHdoaWNoIGxlYWRzIHRvIGEKbWVtb3J5IGxlYWsuIENyZWF0ZSBhIG5ldyBmdW5jdGlvbiB0 byBzcGVjaWZpY2FsbHkgcmVzZXQgaW9yZXEuCgpSZXBvcnRlZC1ieTogTWFpayBXZXNzbGVyIDxt YWlrLndlc3NsZXJAeWFob28uY29tPgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxy b2dlci5wYXVAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxz dGVmYW5vLnN0YWJlbGxpbmlAZXUuY2l0cml4LmNvbT4KCkJhY2twb3J0IHRvIHFlbXUteGVuLXRy YWRpdGlvbmFsLgoKU2lnbmVkLW9mZi1ieTogTWF0dGhldyBEYWxleSA8bWF0dGRAYnVnZnV6ei5j b20+Ci0tLQogaHcveGVuX2Rpc2suYyB8ICAgMjYgKysrKysrKysrKysrKysrKysrKysrKysrLS0K IDEgZmlsZSBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL2h3L3hlbl9kaXNrLmMgYi9ody94ZW5fZGlzay5jCmluZGV4IGVlOGQzNmYuLjI1MGQ4 MDYgMTAwNjQ0Ci0tLSBhL2h3L3hlbl9kaXNrLmMKKysrIGIvaHcveGVuX2Rpc2suYwpAQCAtMTE2 LDYgKzExNiwyOSBAQCBzdHJ1Y3QgWGVuQmxrRGV2IHsKIAogLyogLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSAqLwogCitzdGF0aWMg dm9pZCBpb3JlcV9yZXNldChzdHJ1Y3QgaW9yZXEgKmlvcmVxKQoreworICAgIG1lbXNldCgmaW9y ZXEtPnJlcSwgMCwgc2l6ZW9mKGlvcmVxLT5yZXEpKTsKKyAgICBpb3JlcS0+c3RhdHVzID0gMDsK KyAgICBpb3JlcS0+c3RhcnQgPSAwOworICAgIGlvcmVxLT5wcmVzeW5jID0gMDsKKyAgICBpb3Jl cS0+cG9zdHN5bmMgPSAwOworCisgICAgbWVtc2V0KGlvcmVxLT5kb21pZHMsIDAsIHNpemVvZihp b3JlcS0+ZG9taWRzKSk7CisgICAgbWVtc2V0KGlvcmVxLT5yZWZzLCAwLCBzaXplb2YoaW9yZXEt PnJlZnMpKTsKKyAgICBpb3JlcS0+cHJvdCA9IDA7CisgICAgbWVtc2V0KGlvcmVxLT5wYWdlLCAw LCBzaXplb2YoaW9yZXEtPnBhZ2UpKTsKKyAgICBpb3JlcS0+cGFnZXMgPSBOVUxMOworCisgICAg aW9yZXEtPmFpb19pbmZsaWdodCA9IDA7CisgICAgaW9yZXEtPmFpb19lcnJvcnMgPSAwOworCisg ICAgaW9yZXEtPmJsa2RldiA9IE5VTEw7CisgICAgbWVtc2V0KCZpb3JlcS0+bGlzdCwgMCwgc2l6 ZW9mKGlvcmVxLT5saXN0KSk7CisKKyAgICBxZW11X2lvdmVjX3Jlc2V0KCZpb3JlcS0+dik7Cit9 CisKIHN0YXRpYyBzdHJ1Y3QgaW9yZXEgKmlvcmVxX3N0YXJ0KHN0cnVjdCBYZW5CbGtEZXYgKmJs a2RldikKIHsKICAgICBzdHJ1Y3QgaW9yZXEgKmlvcmVxID0gTlVMTDsKQEAgLTEzMiw3ICsxNTUs NiBAQCBzdGF0aWMgc3RydWN0IGlvcmVxICppb3JlcV9zdGFydChzdHJ1Y3QgWGVuQmxrRGV2ICpi bGtkZXYpCiAJLyogZ2V0IG9uZSBmcm9tIGZyZWVsaXN0ICovCiAJaW9yZXEgPSBMSVNUX0ZJUlNU KCZibGtkZXYtPmZyZWVsaXN0KTsKIAlMSVNUX1JFTU9WRShpb3JlcSwgbGlzdCk7Ci0gICAgICAg IHFlbXVfaW92ZWNfcmVzZXQoJmlvcmVxLT52KTsKICAgICB9CiAgICAgTElTVF9JTlNFUlRfSEVB RCgmYmxrZGV2LT5pbmZsaWdodCwgaW9yZXEsIGxpc3QpOwogICAgIGJsa2Rldi0+cmVxdWVzdHNf aW5mbGlnaHQrKzsKQEAgLTE1Niw3ICsxNzgsNyBAQCBzdGF0aWMgdm9pZCBpb3JlcV9yZWxlYXNl KHN0cnVjdCBpb3JlcSAqaW9yZXEsIGJvb2wgZmluaXNoKQogICAgIHN0cnVjdCBYZW5CbGtEZXYg KmJsa2RldiA9IGlvcmVxLT5ibGtkZXY7CiAKICAgICBMSVNUX1JFTU9WRShpb3JlcSwgbGlzdCk7 Ci0gICAgbWVtc2V0KGlvcmVxLCAwLCBzaXplb2YoKmlvcmVxKSk7CisgICAgaW9yZXFfcmVzZXQo aW9yZXEpOwogICAgIGlvcmVxLT5ibGtkZXYgPSBibGtkZXY7CiAgICAgTElTVF9JTlNFUlRfSEVB RCgmYmxrZGV2LT5mcmVlbGlzdCwgaW9yZXEsIGxpc3QpOwogICAgIGlmIChmaW5pc2gpIHsKLS0g CjEuNy4xMC40CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8v bGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK