From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Daley Subject: [PATCH] xen_disk: fix memory leak Date: Wed, 4 Dec 2013 16:35:17 +1300 Message-ID: <1386128117-12864-1-git-send-email-mattd@bugfuzz.com> References: <1386123378-12699-1-git-send-email-mattd@bugfuzz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1386123378-12699-1-git-send-email-mattd@bugfuzz.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: ilon@medinet.se, Ian Campbell , Stefano Stabellini , Matthew Daley , Ian Jackson , Niklas Bivald , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= List-Id: xen-devel@lists.xenproject.org T24gaW9yZXFfcmVsZWFzZSB0aGUgZnVsbCBpb3JlcSB3YXMgbWVtc2V0IHRvIDAsIGxvb3Npbmcg YWxsIHRoZSBkYXRhCmFuZCBtZW1vcnkgYWxsb2NhdGlvbnMgaW5zaWRlIHRoZSBRRU1VSU9WZWN0 b3IsIHdoaWNoIGxlYWRzIHRvIGEKbWVtb3J5IGxlYWsuIENyZWF0ZSBhIG5ldyBmdW5jdGlvbiB0 byBzcGVjaWZpY2FsbHkgcmVzZXQgaW9yZXEuCgpSZXBvcnRlZC1ieTogTWFpayBXZXNzbGVyIDxt YWlrLndlc3NsZXJAeWFob28uY29tPgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxy b2dlci5wYXVAY2l0cml4LmNvbT4KU2lnbmVkLW9mZi1ieTogU3RlZmFubyBTdGFiZWxsaW5pIDxz dGVmYW5vLnN0YWJlbGxpbmlAZXUuY2l0cml4LmNvbT4KCkJhY2twb3J0IHRvIHFlbXUteGVuLXVu c3RhYmxlLgoKU2lnbmVkLW9mZi1ieTogTWF0dGhldyBEYWxleSA8bWF0dGRAYnVnZnV6ei5jb20+ Ci0tLQp2MjogRml4IHRoZSBhZGRlZCBjb21taXQgbWVzc2FnZSAoInFlbXUteGVuLXRyYWRpdGlv bmFsIiAtPiAicWVtdS14ZW4tdW5zdGFibGUiKQoKIGh3L3hlbl9kaXNrLmMgfCAgIDI2ICsrKysr KysrKysrKysrKysrKysrKysrKy0tCiAxIGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ody94ZW5fZGlzay5jIGIvaHcveGVuX2Rpc2su YwppbmRleCBlZThkMzZmLi4yNTBkODA2IDEwMDY0NAotLS0gYS9ody94ZW5fZGlzay5jCisrKyBi L2h3L3hlbl9kaXNrLmMKQEAgLTExNiw2ICsxMTYsMjkgQEAgc3RydWN0IFhlbkJsa0RldiB7CiAK IC8qIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0gKi8KIAorc3RhdGljIHZvaWQgaW9yZXFfcmVzZXQoc3RydWN0IGlvcmVxICppb3Jl cSkKK3sKKyAgICBtZW1zZXQoJmlvcmVxLT5yZXEsIDAsIHNpemVvZihpb3JlcS0+cmVxKSk7Cisg ICAgaW9yZXEtPnN0YXR1cyA9IDA7CisgICAgaW9yZXEtPnN0YXJ0ID0gMDsKKyAgICBpb3JlcS0+ cHJlc3luYyA9IDA7CisgICAgaW9yZXEtPnBvc3RzeW5jID0gMDsKKworICAgIG1lbXNldChpb3Jl cS0+ZG9taWRzLCAwLCBzaXplb2YoaW9yZXEtPmRvbWlkcykpOworICAgIG1lbXNldChpb3JlcS0+ cmVmcywgMCwgc2l6ZW9mKGlvcmVxLT5yZWZzKSk7CisgICAgaW9yZXEtPnByb3QgPSAwOworICAg IG1lbXNldChpb3JlcS0+cGFnZSwgMCwgc2l6ZW9mKGlvcmVxLT5wYWdlKSk7CisgICAgaW9yZXEt PnBhZ2VzID0gTlVMTDsKKworICAgIGlvcmVxLT5haW9faW5mbGlnaHQgPSAwOworICAgIGlvcmVx LT5haW9fZXJyb3JzID0gMDsKKworICAgIGlvcmVxLT5ibGtkZXYgPSBOVUxMOworICAgIG1lbXNl dCgmaW9yZXEtPmxpc3QsIDAsIHNpemVvZihpb3JlcS0+bGlzdCkpOworCisgICAgcWVtdV9pb3Zl Y19yZXNldCgmaW9yZXEtPnYpOworfQorCiBzdGF0aWMgc3RydWN0IGlvcmVxICppb3JlcV9zdGFy dChzdHJ1Y3QgWGVuQmxrRGV2ICpibGtkZXYpCiB7CiAgICAgc3RydWN0IGlvcmVxICppb3JlcSA9 IE5VTEw7CkBAIC0xMzIsNyArMTU1LDYgQEAgc3RhdGljIHN0cnVjdCBpb3JlcSAqaW9yZXFfc3Rh cnQoc3RydWN0IFhlbkJsa0RldiAqYmxrZGV2KQogCS8qIGdldCBvbmUgZnJvbSBmcmVlbGlzdCAq LwogCWlvcmVxID0gTElTVF9GSVJTVCgmYmxrZGV2LT5mcmVlbGlzdCk7CiAJTElTVF9SRU1PVkUo aW9yZXEsIGxpc3QpOwotICAgICAgICBxZW11X2lvdmVjX3Jlc2V0KCZpb3JlcS0+dik7CiAgICAg fQogICAgIExJU1RfSU5TRVJUX0hFQUQoJmJsa2Rldi0+aW5mbGlnaHQsIGlvcmVxLCBsaXN0KTsK ICAgICBibGtkZXYtPnJlcXVlc3RzX2luZmxpZ2h0Kys7CkBAIC0xNTYsNyArMTc4LDcgQEAgc3Rh dGljIHZvaWQgaW9yZXFfcmVsZWFzZShzdHJ1Y3QgaW9yZXEgKmlvcmVxLCBib29sIGZpbmlzaCkK ICAgICBzdHJ1Y3QgWGVuQmxrRGV2ICpibGtkZXYgPSBpb3JlcS0+YmxrZGV2OwogCiAgICAgTElT VF9SRU1PVkUoaW9yZXEsIGxpc3QpOwotICAgIG1lbXNldChpb3JlcSwgMCwgc2l6ZW9mKCppb3Jl cSkpOworICAgIGlvcmVxX3Jlc2V0KGlvcmVxKTsKICAgICBpb3JlcS0+YmxrZGV2ID0gYmxrZGV2 OwogICAgIExJU1RfSU5TRVJUX0hFQUQoJmJsa2Rldi0+ZnJlZWxpc3QsIGlvcmVxLCBsaXN0KTsK ICAgICBpZiAoZmluaXNoKSB7Ci0tIAoxLjcuMTAuNAoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==