From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH 1/2] amd/passthrough: Do not leak domain mappings from do_invalidate_dte() Date: Wed, 4 Dec 2013 15:09:15 +0000 Message-ID: <1386169756-8406-2-git-send-email-andrew.cooper3@citrix.com> References: <1386169756-8406-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1386169756-8406-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: Andrew Cooper , Keir Fraser , Suravee Suthikulpanit , Jan Beulich List-Id: xen-devel@lists.xenproject.org Coverity ID: 1135379 Signed-off-by: Andrew Cooper CC: Keir Fraser CC: Jan Beulich CC: Suravee Suthikulpanit --- xen/drivers/passthrough/amd/iommu_guest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_guest.c b/xen/drivers/passthrough/amd/iommu_guest.c index 952600a..7687cf1 100644 --- a/xen/drivers/passthrough/amd/iommu_guest.c +++ b/xen/drivers/passthrough/amd/iommu_guest.c @@ -433,7 +433,10 @@ static int do_invalidate_dte(struct domain *d, cmd_entry_t *cmd) /* Do not update host dte before gcr3 has been set */ if ( gcr3_gfn == 0 ) + { + unmap_domain_page(dte_base); return 0; + } gcr3_mfn = mfn_x(get_gfn(d, gcr3_gfn, &p2mt)); put_gfn(d, gcr3_gfn); @@ -446,6 +449,7 @@ static int do_invalidate_dte(struct domain *d, cmd_entry_t *cmd) { AMD_IOMMU_DEBUG("%s: Fail to find iommu for bdf %x!\n", __func__, mbdf); + unmap_domain_page(dte_base); return -ENODEV; } -- 1.7.10.4