xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Keir Fraser <keir@xen.org>, Jan Beulich <JBeulich@suse.com>,
	Tim Deegan <tim@xen.org>
Subject: [PATCH 2/2] xen/page_alloc: Defer the domain mapping in scrub_one_page()
Date: Wed, 4 Dec 2013 15:09:16 +0000	[thread overview]
Message-ID: <1386169756-8406-3-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1386169756-8406-1-git-send-email-andrew.cooper3@citrix.com>

This avoids a resource leak and needless playing with the pagetables in the
case that the page is broken.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Keir Fraser <keir@xen.org>
CC: Jan Beulich <JBeulich@suse.com>
CC: Tim Deegan <tim@xen.org>
---
 xen/common/page_alloc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 8002bd2..5f484a2 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1652,11 +1652,13 @@ __initcall(pagealloc_keyhandler_init);
 
 void scrub_one_page(struct page_info *pg)
 {
-    void *p = __map_domain_page(pg);
+    void *p;
 
     if ( unlikely(pg->count_info & PGC_broken) )
         return;
 
+    p = __map_domain_page(pg);
+
 #ifndef NDEBUG
     /* Avoid callers relying on allocations returning zeroed pages. */
     memset(p, 0xc2, PAGE_SIZE);
-- 
1.7.10.4

  parent reply	other threads:[~2013-12-04 15:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-04 15:09 [PATCH 0/2] Coverity fixes for map_domain_page() mismatches Andrew Cooper
2013-12-04 15:09 ` [PATCH 1/2] amd/passthrough: Do not leak domain mappings from do_invalidate_dte() Andrew Cooper
2013-12-04 15:22   ` Jan Beulich
2013-12-04 15:30     ` Andrew Cooper
2013-12-04 16:44     ` [PATCH v2 " Andrew Cooper
2013-12-04 16:49       ` Jan Beulich
2013-12-04 17:59         ` [PATCH v3 " Andrew Cooper
2013-12-06  8:37           ` Jan Beulich
2013-12-09 10:08           ` Jan Beulich
2013-12-09 18:33           ` Suravee Suthikulanit
2013-12-09 18:34             ` Andrew Cooper
2013-12-09 18:41             ` [PATCH v4 " Andrew Cooper
2013-12-09 20:02               ` Suravee Suthikulpanit
2013-12-04 15:09 ` Andrew Cooper [this message]
2013-12-04 15:23   ` [PATCH 2/2] xen/page_alloc: Defer the domain mapping in scrub_one_page() Jan Beulich
2013-12-09 10:09   ` Jan Beulich
2013-12-09 11:02     ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386169756-8406-3-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).