From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xen.org
Cc: julien.grall@linaro.org, ian.campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ
Date: Fri, 6 Dec 2013 17:26:43 +0000 [thread overview]
Message-ID: <1386350808-13648-1-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312061715200.7093@kaball.uk.xensource.com>
From: Julien Grall <julien.grall@linaro.org>
From: Julien Grall <julien.grall@linaro.org>
When Xen needs to EOI a physical IRQ, we should use the IRQ number
in irq_desc instead of the virtual IRQ.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
xen/arch/arm/gic.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
index 43c11cb..7e87acb 100644
--- a/xen/arch/arm/gic.c
+++ b/xen/arch/arm/gic.c
@@ -880,7 +880,7 @@ static void gic_irq_eoi(void *info)
static void maintenance_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs)
{
- int i = 0, virq;
+ int i = 0, virq, pirq;
uint32_t lr;
struct vcpu *v = current;
uint64_t eisr = GICH[GICH_EISR0] | (((uint64_t) GICH[GICH_EISR1]) << 32);
@@ -916,6 +916,7 @@ static void maintenance_interrupt(int irq, void *dev_id, struct cpu_user_regs *r
/* Assume only one pcpu needs to EOI the irq */
cpu = p->desc->arch.eoi_cpu;
eoi = 1;
+ pirq = p->desc->irq;
}
list_del_init(&p->inflight);
spin_unlock_irq(&v->arch.vgic.lock);
@@ -924,10 +925,10 @@ static void maintenance_interrupt(int irq, void *dev_id, struct cpu_user_regs *r
/* this is not racy because we can't receive another irq of the
* same type until we EOI it. */
if ( cpu == smp_processor_id() )
- gic_irq_eoi((void*)(uintptr_t)virq);
+ gic_irq_eoi((void*)(uintptr_t)pirq);
else
on_selected_cpus(cpumask_of(cpu),
- gic_irq_eoi, (void*)(uintptr_t)virq, 0);
+ gic_irq_eoi, (void*)(uintptr_t)pirq, 0);
}
i++;
--
1.7.10.4
next prev parent reply other threads:[~2013-12-06 17:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 17:26 [PATCH 0/6] interrupt handling fixes Stefano Stabellini
2013-12-06 17:26 ` Stefano Stabellini [this message]
2013-12-09 17:10 ` [PATCH 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ Ian Campbell
2013-12-06 17:26 ` [PATCH 2/6] xen/arm: track the state of guest IRQs Stefano Stabellini
2013-12-09 17:38 ` Ian Campbell
2013-12-10 13:02 ` Stefano Stabellini
2013-12-06 17:26 ` [PATCH 3/6] xen/arm: do not add a second irq to the LRs if one is already present Stefano Stabellini
2013-12-06 17:26 ` [PATCH 4/6] xen/arm: implement gic_irq_enable and gic_irq_disable Stefano Stabellini
2013-12-06 18:29 ` Julien Grall
2013-12-09 17:42 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 5/6] xen/arm: Only enable physical IRQs when the guest asks Stefano Stabellini
2013-12-06 18:28 ` Julien Grall
2013-12-09 12:26 ` Stefano Stabellini
2013-12-09 17:44 ` Ian Campbell
2013-12-06 17:26 ` [PATCH 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ Stefano Stabellini
2013-12-06 17:56 ` Julien Grall
2013-12-09 12:37 ` Stefano Stabellini
2013-12-09 12:48 ` Ian Campbell
2013-12-06 18:24 ` Julien Grall
2013-12-09 12:50 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386350808-13648-1-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).