From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: julien.grall@citrix.com, Ian.Campbell@citrix.com,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH v2 3/6] xen/arm: do not add a second irq to the LRs if one is already present
Date: Tue, 10 Dec 2013 13:06:05 +0000 [thread overview]
Message-ID: <1386680768-15543-3-git-send-email-stefano.stabellini@eu.citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1312101302200.7093@kaball.uk.xensource.com>
When the guest re-enable IRQs, do not add guest IRQs to LRs twice.
Suggested-by: Julien Grall <julien.grall@linaro.org>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---
xen/arch/arm/vgic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
index 2f7acca..75df571 100644
--- a/xen/arch/arm/vgic.c
+++ b/xen/arch/arm/vgic.c
@@ -370,7 +370,7 @@ static void vgic_enable_irqs(struct vcpu *v, uint32_t r, int n)
irq = i + (32 * n);
p = irq_to_pending(v, irq);
set_bit(_GIC_IRQ_GUEST_ENABLED, &p->status);
- if ( !list_empty(&p->inflight) )
+ if ( !list_empty(&p->inflight) && !test_bit(_GIC_IRQ_GUEST_VISIBLE, &p->status) )
gic_set_guest_irq(v, irq, GICH_LR_PENDING, p->priority);
i++;
}
--
1.7.10.4
next prev parent reply other threads:[~2013-12-10 13:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 13:05 [PATCH v2 0/6] interrupt handling fixes Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 1/6] xen/arm: Physical IRQ is not always equal to virtual IRQ Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 2/6] xen/arm: track the state of guest IRQs Stefano Stabellini
2013-12-10 13:06 ` Stefano Stabellini [this message]
2013-12-10 15:22 ` [PATCH v2 3/6] xen/arm: do not add a second irq to the LRs if one is already present Ian Campbell
2013-12-10 13:06 ` [PATCH v2 4/6] xen/arm: implement gic_irq_enable and gic_irq_disable Stefano Stabellini
2013-12-10 13:06 ` [PATCH v2 5/6] xen/arm: Only enable physical IRQs when the guest asks Stefano Stabellini
2013-12-10 15:18 ` Ian Campbell
2013-12-10 13:06 ` [PATCH v2 6/6] xen/arm: disable a physical IRQ when the guest disables the corresponding IRQ Stefano Stabellini
2013-12-10 15:20 ` Ian Campbell
2013-12-10 18:36 ` Stefano Stabellini
2013-12-11 10:28 ` Ian Campbell
2013-12-11 19:01 ` Stefano Stabellini
2013-12-12 10:21 ` Ian Campbell
2013-12-10 15:22 ` [PATCH v2 0/6] interrupt handling fixes Ian Campbell
2013-12-10 15:30 ` Julien Grall
2013-12-10 15:36 ` Stefano Stabellini
2013-12-10 16:06 ` Ian Campbell
2013-12-10 16:46 ` Stefano Stabellini
2013-12-10 18:52 ` Stefano Stabellini
2013-12-10 18:34 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386680768-15543-3-git-send-email-stefano.stabellini@eu.citrix.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).