xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: David Vrabel <david.vrabel@citrix.com>
To: xen-devel@lists.xen.org
Cc: Keir Fraser <keir@xen.org>,
	David Vrabel <david.vrabel@citrix.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: [PATCHv7 0/2] Xen: FIFO-based event channel fixes
Date: Tue, 10 Dec 2013 13:56:58 +0000	[thread overview]
Message-ID: <1386683820-9834-1-git-send-email-david.vrabel@citrix.com> (raw)

This series fixes two bugs in the FIFO-based event channel ABI.

With the first bug, the priority of a newly bound event may not be the
default (it might have been an old priority for that port or 0).

The second bug is triggered by moving events between queues (either
moving VCPUs or changing their priority).  This would cause events to
be lost.

Testing with a process continually moving all event channels between
VCPUs has been done.  This would previously fail in under an hour but
with this fix the system stayed up for over 10 days.

It has also been through a complete set of XenServer's automated
regression tests and no issues were found.

Changes in v7:

- Add patch to initialize priority of all newly bound events.

Changes in v6:

- Limit loop to acquire old_q->lock to 3 iterations.

Changes in v5:

- Only set READY bits for new heads.
- Rework old tail bug fix to cover all cases.

Changes in v4:

- const struct domain *
- Clear BUSY with existing cmpxchg() where possible.
- Fix BUSY bit debug output.

Changes in v3:

- Use a new BUSY bit to block guests from clearing UNMASKED, this is
  lower overhead than the previous solution (which required a
  hypercall).
- Fix another problem with moving events between queues.
- Add evtchn->last_vpcu_id and evtchn->last_priority instead of
  evtchn->q.  This keeps the structure at 32 bytes long.

Changes in v2:

- Add MAINTAINERS patch
- Remove some unnecessary temporary pending state clears
- Add fix for DoS

David

             reply	other threads:[~2013-12-10 13:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-10 13:56 David Vrabel [this message]
2013-12-10 13:56 ` [PATCH 1/2] evtchn/fifo: initialize priority when events are bound David Vrabel
2013-12-10 14:50   ` Jan Beulich
2013-12-10 14:54     ` David Vrabel
2013-12-16 13:45     ` David Vrabel
2014-01-06 18:04       ` David Vrabel
2014-01-07 15:50   ` Keir Fraser
2013-12-10 13:57 ` [PATCH 2/2] evtchn/fifo: don't corrupt queues if an old tail is linked David Vrabel
2013-12-10 14:55   ` Jan Beulich
2014-01-07 15:50   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386683820-9834-1-git-send-email-david.vrabel@citrix.com \
    --to=david.vrabel@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).