From: Daniel Kiper <daniel.kiper@oracle.com>
To: andrew.cooper3@citrix.com, david.vrabel@citrix.com,
jbeulich@suse.com, keir@xen.org, xen-devel@lists.xenproject.org
Cc: Daniel Kiper <daniel.kiper@oracle.com>
Subject: [PATCH v2] kexec/x86: Do not map crash kernel area
Date: Wed, 11 Dec 2013 11:26:27 +0100 [thread overview]
Message-ID: <1386757587-16969-1-git-send-email-daniel.kiper@oracle.com> (raw)
It looks that crash kernel area was mapped deliberately. However,
there is no any references to that mapping in new and even old kexec
code. Additionally, commit messages does not explain why this mapping
was made. kexec and kdump tests (new and old version) show that they are
working without this mapping. Hence, if it is not used and everything
works with out it then remove relevant code and do not crate crash
kernel area mapping anymore.
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
---
xen/arch/x86/setup.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c
index f07ee2b..4833ca3 100644
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -1097,9 +1097,7 @@ void __init __start_xen(unsigned long mbi_p)
mod[i].mod_start,
PFN_UP(mod[i].mod_end), PAGE_HYPERVISOR);
}
- map_pages_to_xen((unsigned long)__va(kexec_crash_area.start),
- kexec_crash_area.start >> PAGE_SHIFT,
- PFN_UP(kexec_crash_area.size), PAGE_HYPERVISOR);
+
xen_virt_end = ((unsigned long)_end + (1UL << L2_PAGETABLE_SHIFT) - 1) &
~((1UL << L2_PAGETABLE_SHIFT) - 1);
destroy_xen_mappings(xen_virt_end, XEN_VIRT_START + BOOTSTRAP_MAP_BASE);
--
1.7.10.4
reply other threads:[~2013-12-11 10:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386757587-16969-1-git-send-email-daniel.kiper@oracle.com \
--to=daniel.kiper@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).