xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Dario Faggioli <dario.faggioli@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, ian.campbell@citrix.com,
	xen-devel@lists.xen.org
Subject: Re: [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install
Date: Thu, 12 Dec 2013 09:49:11 +0100	[thread overview]
Message-ID: <1386838151.5488.90.camel@Solace> (raw)
In-Reply-To: <1386778305-29995-5-git-send-email-wei.liu2@citrix.com>


[-- Attachment #1.1: Type: text/plain, Size: 1014 bytes --]

On mer, 2013-12-11 at 16:11 +0000, Wei Liu wrote:
> diff --git a/ts-ovmf-debian-install b/ts-ovmf-debian-install
> new file mode 100755
> index 0000000..2e19348
> --- /dev/null
> +++ b/ts-ovmf-debian-install

> +sub start () {
> +    target_cmd_root($ho, "$xl create $gho->{CfgPath}", 100);
> +}
> +
Something like "toolstack()->{Command}" instead of "xl" ?

I don't know how important this is, though, as I don't think this has
much chances to work with xend, has it?

> +rewrite_config_nocd();
> +start();
> +guest_await_dhcp_tcp($gho,300);
> +guest_check_up($gho);
>
Does this mean that the guest remains up after the end of the test? This
is also probably not a big deal, but, shouldn't we tear it down?

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2013-12-12  8:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11 16:11 [PATCH RFC V2 0/6] OSSTest: OVMF test job Wei Liu
2013-12-11 16:11 ` [PATCH RFC V2 1/6] TestSupport.pm: add bios option to guest config file Wei Liu
2013-12-11 16:11 ` [PATCH RFC V2 2/6] Build OVMF for Xen-unstable Wei Liu
2013-12-12 15:21   ` Ian Jackson
2013-12-12 15:34     ` Wei Liu
2013-12-12 15:35       ` Ian Campbell
2013-12-12 16:34         ` Ian Jackson
2013-12-12 17:26           ` Ian Campbell
2013-12-11 16:11 ` [PATCH RFC V2 3/6] Debian.pm: factor out preseed_base Wei Liu
2013-12-12 15:25   ` Ian Jackson
2013-12-12 16:19   ` Ian Jackson
2013-12-12 16:42     ` Wei Liu
2013-12-12 16:50       ` Ian Jackson
2013-12-11 16:11 ` [PATCH RFC V2 4/6] Introduce ts-ovmf-debian-install Wei Liu
2013-12-12  8:49   ` Dario Faggioli [this message]
2013-12-12 12:16     ` Wei Liu
2013-12-12 12:24       ` Dario Faggioli
2013-12-12 12:29         ` Wei Liu
2013-12-12 16:26         ` Ian Jackson
2013-12-12 16:37           ` Dario Faggioli
2013-12-12 15:40   ` Ian Jackson
2013-12-12 15:51     ` Wei Liu
2013-12-12 16:23       ` Ian Jackson
2013-12-12 17:57     ` Wei Liu
2013-12-12 18:17       ` Wei Liu
2013-12-11 16:11 ` [PATCH RFC V2 5/6] make-flight: OVMF test filght Wei Liu
2013-12-12 16:18   ` Ian Jackson
2013-12-11 16:11 ` [PATCH RFC V2 6/6] sg-run-job: OVMF job Wei Liu
2013-12-12 15:42   ` Ian Jackson
2013-12-12 15:52     ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386838151.5488.90.camel@Solace \
    --to=dario.faggioli@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).