From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
mukesh.rathor@oracle.com, tim@xen.org, jbeulich@suse.com,
boris.ostrovsky@oracle.com, david.vrabel@citrix.com
Cc: Ian Campbell <ian.campbell@citrix.com>
Subject: [PATCH V10 06/14] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings
Date: Thu, 12 Dec 2013 21:10:13 -0500 [thread overview]
Message-ID: <1386900621-27528-7-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1386900621-27528-1-git-send-email-konrad.wilk@oracle.com>
From: Ian Campbell <ian.campbell@citrix.com>
Squeezing the necessary fields into the existing XENMEM_add_to_physmap
interface was proving to be a bit tricky so we have decided to go with
a new interface upstream (the XENMAPSPACE_gmfn_foreign interface using
XENMEM_add_to_physmap was never committed anywhere). This interface
also allows for batching which was impossible to support at the same
time as foreign mfns in the old interface.
This reverts the relevant parts of "PVH: basic and header changes,
elfnote changes, ..." and followups and trivially converts
pvh_add_to_xen_p2m over.
Acked-by: Mukesh Rathor <mukesh.rathor@oracle.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
arch/x86/xen/mmu.c | 18 ++++++++++++------
include/xen/interface/memory.h | 5 +----
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index c7de065..e334134 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -2532,13 +2532,19 @@ static int pvh_add_to_xen_p2m(unsigned long lpfn, unsigned long fgmfn,
unsigned int domid)
{
int rc;
- struct xen_add_to_physmap xatp = { .foreign_domid = domid };
+ struct xen_add_to_physmap_range xatp = {
+ .domid = DOMID_SELF,
+ .foreign_domid = domid,
+ .size = 1,
+ .space = XENMAPSPACE_gmfn_foreign,
+ };
+ xen_ulong_t idx = fgmfn;
+ xen_pfn_t gpfn = lpfn;
+
+ set_xen_guest_handle(xatp.idxs, &idx);
+ set_xen_guest_handle(xatp.gpfns, &gpfn);
- xatp.gpfn = lpfn;
- xatp.idx = fgmfn;
- xatp.domid = DOMID_SELF;
- xatp.space = XENMAPSPACE_gmfn_foreign;
- rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap, &xatp);
+ rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp);
if (rc)
pr_warn("d0: Failed to map pfn (0x%lx) to mfn (0x%lx) rc:%d\n",
lpfn, fgmfn, rc);
diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h
index a122164..2ecfe4f 100644
--- a/include/xen/interface/memory.h
+++ b/include/xen/interface/memory.h
@@ -175,10 +175,7 @@ struct xen_add_to_physmap {
uint16_t size;
/* Source mapping space. */
- uint16_t space;
- domid_t foreign_domid; /* IFF XENMAPSPACE_gmfn_foreign */
-
-#define XENMAPIDX_grant_table_status 0x80000000
+ unsigned int space;
/* Index into source mapping space. */
xen_ulong_t idx;
--
1.7.7.6
next prev parent reply other threads:[~2013-12-13 2:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1386900621-27528-1-git-send-email-konrad.wilk@oracle.com>
2013-12-13 2:10 ` [PATCH V10 01/14] xen/pvh: Support ParaVirtualized Hardware extensions Konrad Rzeszutek Wilk
2013-12-13 10:44 ` David Vrabel
[not found] ` <52AAE50F.3000009@citrix.com>
2013-12-13 14:32 ` Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 02/14] xen/pvh: Extend vcpu_guest_context, p2m, event, and XenBus Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 03/14] xen/pvh: Implement MMU changes for PVH Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 04/14] xen/pvh: bootup and setup (E820) related changes Konrad Rzeszutek Wilk
2013-12-13 17:55 ` Boris Ostrovsky
[not found] ` <52AB4A0E.5010606@oracle.com>
2013-12-17 21:39 ` Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 05/14] xen/pvh: balloon and grant changes Konrad Rzeszutek Wilk
2013-12-13 11:02 ` David Vrabel
2013-12-13 11:56 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1312131147230.8667@kaball.uk.xensource.com>
2013-12-13 14:36 ` Konrad Rzeszutek Wilk
[not found] ` <20131213143620.GH2923@phenom.dumpdata.com>
2013-12-13 14:49 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1312131448340.8667@kaball.uk.xensource.com>
2013-12-13 14:59 ` Konrad Rzeszutek Wilk
[not found] ` <20131213145937.GB4770@phenom.dumpdata.com>
2013-12-13 15:34 ` Stefano Stabellini
[not found] ` <alpine.DEB.2.02.1312131530030.8667@kaball.uk.xensource.com>
2013-12-13 15:47 ` Konrad Rzeszutek Wilk
[not found] ` <20131213154722.GA7214@phenom.dumpdata.com>
2013-12-13 15:51 ` Stefano Stabellini
2013-12-13 2:10 ` Konrad Rzeszutek Wilk [this message]
2013-12-13 2:10 ` [PATCH V10 07/14] xen/x86: remove duplicated include from enlighten.c Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 08/14] x86/xen: Use __pa_symbol instead of __pa on C visible symbols Konrad Rzeszutek Wilk
2013-12-13 11:04 ` David Vrabel
[not found] ` <52AAE9BD.9060305@citrix.com>
2013-12-13 14:24 ` Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI Konrad Rzeszutek Wilk
2013-12-13 11:35 ` David Vrabel
[not found] ` <52AAF100.2020002@citrix.com>
2013-12-13 14:27 ` Konrad Rzeszutek Wilk
[not found] ` <20131213142746.GE2923@phenom.dumpdata.com>
2013-12-13 14:30 ` David Vrabel
2013-12-13 2:10 ` [PATCH V10 10/14] xen/pvh: specify xen features strings cleanly for PVH Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 11/14] xen/pvh: remove code to map iomem from guest Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 12/14] xen/pvh: Use ballooning to allocate grant table pages [v2] Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 13/14] x86/xen: remove depends on CONFIG_EXPERIMENTAL Konrad Rzeszutek Wilk
2013-12-13 2:10 ` [PATCH V10 14/14] xen/pvh: vcpu info placement, load CS selector, and remove debug printk Konrad Rzeszutek Wilk
2013-12-13 11:34 ` David Vrabel
[not found] ` <1386900621-27528-3-git-send-email-konrad.wilk@oracle.com>
2013-12-13 10:56 ` [PATCH V10 02/14] xen/pvh: Extend vcpu_guest_context, p2m, event, and XenBus David Vrabel
[not found] ` <52AAE7D8.2030602@citrix.com>
2013-12-13 14:26 ` Konrad Rzeszutek Wilk
[not found] ` <20131213142651.GD2923@phenom.dumpdata.com>
2013-12-13 14:59 ` Stefano Stabellini
2013-12-13 11:37 ` [PATCH v10] Repost of PVH patches for Linux David Vrabel
[not found] ` <52AAF176.3020102@citrix.com>
2013-12-13 14:30 ` Konrad Rzeszutek Wilk
[not found] ` <1386900621-27528-4-git-send-email-konrad.wilk@oracle.com>
2013-12-13 16:54 ` [PATCH V10 03/14] xen/pvh: Implement MMU changes for PVH Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386900621-27528-7-git-send-email-konrad.wilk@oracle.com \
--to=konrad@kernel.org \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mukesh.rathor@oracle.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).