xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
	george.dunlap@eu.citrix.com, ian.jackson@eu.citrix.com,
	mukesh.rathor@oracle.com, tim@xen.org, jbeulich@suse.com,
	boris.ostrovsky@oracle.com, david.vrabel@citrix.com
Cc: Alexander Duyck <alexander.h.duyck@intel.com>
Subject: [PATCH V10 08/14] x86/xen: Use __pa_symbol instead of __pa on C visible symbols
Date: Thu, 12 Dec 2013 21:10:15 -0500	[thread overview]
Message-ID: <1386900621-27528-9-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1386900621-27528-1-git-send-email-konrad.wilk@oracle.com>

From: Alexander Duyck <alexander.h.duyck@intel.com>

This change updates a few of the functions to use __pa_symbol when
translating C visible symbols instead of __pa.  By using __pa_symbol we are
able to drop a few extra lines of code as don't have to test to see if the
virtual pointer is a part of the kernel text or just standard virtual memory.

Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 arch/x86/xen/mmu.c |   21 +++++++++++----------
 1 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index e334134..1d1fbdb 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -1508,7 +1508,8 @@ static int xen_pgd_alloc(struct mm_struct *mm)
 
 		if (user_pgd != NULL) {
 			user_pgd[pgd_index(VSYSCALL_START)] =
-				__pgd(__pa(level3_user_vsyscall) | _PAGE_TABLE);
+				__pgd(__pa_symbol(level3_user_vsyscall) |
+				      _PAGE_TABLE);
 			ret = 0;
 		}
 
@@ -1971,10 +1972,10 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
 	 * pgd.
 	 */
 	if (xen_feature(XENFEAT_writable_page_tables)) {
-		native_write_cr3(__pa(init_level4_pgt));
+		native_write_cr3(__pa_symbol(init_level4_pgt));
 	} else {
 		xen_mc_batch();
-		__xen_write_cr3(true, __pa(init_level4_pgt));
+		__xen_write_cr3(true, __pa_symbol(init_level4_pgt));
 		xen_mc_issue(PARAVIRT_LAZY_CPU);
 	}
 	/* We can't that easily rip out L3 and L2, as the Xen pagetables are
@@ -1997,10 +1998,10 @@ static RESERVE_BRK_ARRAY(pmd_t, swapper_kernel_pmd, PTRS_PER_PMD);
 
 static void __init xen_write_cr3_init(unsigned long cr3)
 {
-	unsigned long pfn = PFN_DOWN(__pa(swapper_pg_dir));
+	unsigned long pfn = PFN_DOWN(__pa_symbol(swapper_pg_dir));
 
-	BUG_ON(read_cr3() != __pa(initial_page_table));
-	BUG_ON(cr3 != __pa(swapper_pg_dir));
+	BUG_ON(read_cr3() != __pa_symbol(initial_page_table));
+	BUG_ON(cr3 != __pa_symbol(swapper_pg_dir));
 
 	/*
 	 * We are switching to swapper_pg_dir for the first time (from
@@ -2024,7 +2025,7 @@ static void __init xen_write_cr3_init(unsigned long cr3)
 	pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE, pfn);
 
 	pin_pagetable_pfn(MMUEXT_UNPIN_TABLE,
-			  PFN_DOWN(__pa(initial_page_table)));
+			  PFN_DOWN(__pa_symbol(initial_page_table)));
 	set_page_prot(initial_page_table, PAGE_KERNEL);
 	set_page_prot(initial_kernel_pmd, PAGE_KERNEL);
 
@@ -2049,7 +2050,7 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
 
 	copy_page(initial_page_table, pgd);
 	initial_page_table[KERNEL_PGD_BOUNDARY] =
-		__pgd(__pa(initial_kernel_pmd) | _PAGE_PRESENT);
+		__pgd(__pa_symbol(initial_kernel_pmd) | _PAGE_PRESENT);
 
 	set_page_prot(initial_kernel_pmd, PAGE_KERNEL_RO);
 	set_page_prot(initial_page_table, PAGE_KERNEL_RO);
@@ -2058,8 +2059,8 @@ void __init xen_setup_kernel_pagetable(pgd_t *pgd, unsigned long max_pfn)
 	pin_pagetable_pfn(MMUEXT_UNPIN_TABLE, PFN_DOWN(__pa(pgd)));
 
 	pin_pagetable_pfn(MMUEXT_PIN_L3_TABLE,
-			  PFN_DOWN(__pa(initial_page_table)));
-	xen_write_cr3(__pa(initial_page_table));
+			  PFN_DOWN(__pa_symbol(initial_page_table)));
+	xen_write_cr3(__pa_symbol(initial_page_table));
 
 	memblock_reserve(__pa(xen_start_info->pt_base),
 			 xen_start_info->nr_pt_frames * PAGE_SIZE);
-- 
1.7.7.6

  parent reply	other threads:[~2013-12-13  2:10 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1386900621-27528-1-git-send-email-konrad.wilk@oracle.com>
2013-12-13  2:10 ` [PATCH V10 01/14] xen/pvh: Support ParaVirtualized Hardware extensions Konrad Rzeszutek Wilk
2013-12-13 10:44   ` David Vrabel
     [not found]   ` <52AAE50F.3000009@citrix.com>
2013-12-13 14:32     ` Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 02/14] xen/pvh: Extend vcpu_guest_context, p2m, event, and XenBus Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 03/14] xen/pvh: Implement MMU changes for PVH Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 04/14] xen/pvh: bootup and setup (E820) related changes Konrad Rzeszutek Wilk
2013-12-13 17:55   ` Boris Ostrovsky
     [not found]   ` <52AB4A0E.5010606@oracle.com>
2013-12-17 21:39     ` Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 05/14] xen/pvh: balloon and grant changes Konrad Rzeszutek Wilk
2013-12-13 11:02   ` David Vrabel
2013-12-13 11:56   ` Stefano Stabellini
     [not found]   ` <alpine.DEB.2.02.1312131147230.8667@kaball.uk.xensource.com>
2013-12-13 14:36     ` Konrad Rzeszutek Wilk
     [not found]     ` <20131213143620.GH2923@phenom.dumpdata.com>
2013-12-13 14:49       ` Stefano Stabellini
     [not found]       ` <alpine.DEB.2.02.1312131448340.8667@kaball.uk.xensource.com>
2013-12-13 14:59         ` Konrad Rzeszutek Wilk
     [not found]         ` <20131213145937.GB4770@phenom.dumpdata.com>
2013-12-13 15:34           ` Stefano Stabellini
     [not found]           ` <alpine.DEB.2.02.1312131530030.8667@kaball.uk.xensource.com>
2013-12-13 15:47             ` Konrad Rzeszutek Wilk
     [not found]             ` <20131213154722.GA7214@phenom.dumpdata.com>
2013-12-13 15:51               ` Stefano Stabellini
2013-12-13  2:10 ` [PATCH V10 06/14] xen: x86 pvh: use XENMEM_add_to_physmap_range for foreign gmfn mappings Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 07/14] xen/x86: remove duplicated include from enlighten.c Konrad Rzeszutek Wilk
2013-12-13  2:10 ` Konrad Rzeszutek Wilk [this message]
2013-12-13 11:04   ` [PATCH V10 08/14] x86/xen: Use __pa_symbol instead of __pa on C visible symbols David Vrabel
     [not found]   ` <52AAE9BD.9060305@citrix.com>
2013-12-13 14:24     ` Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 09/14] xen: implement updated XENMEM_add_to_physmap_range ABI Konrad Rzeszutek Wilk
2013-12-13 11:35   ` David Vrabel
     [not found]   ` <52AAF100.2020002@citrix.com>
2013-12-13 14:27     ` Konrad Rzeszutek Wilk
     [not found]     ` <20131213142746.GE2923@phenom.dumpdata.com>
2013-12-13 14:30       ` David Vrabel
2013-12-13  2:10 ` [PATCH V10 10/14] xen/pvh: specify xen features strings cleanly for PVH Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 11/14] xen/pvh: remove code to map iomem from guest Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 12/14] xen/pvh: Use ballooning to allocate grant table pages [v2] Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 13/14] x86/xen: remove depends on CONFIG_EXPERIMENTAL Konrad Rzeszutek Wilk
2013-12-13  2:10 ` [PATCH V10 14/14] xen/pvh: vcpu info placement, load CS selector, and remove debug printk Konrad Rzeszutek Wilk
2013-12-13 11:34   ` David Vrabel
     [not found] ` <1386900621-27528-3-git-send-email-konrad.wilk@oracle.com>
2013-12-13 10:56   ` [PATCH V10 02/14] xen/pvh: Extend vcpu_guest_context, p2m, event, and XenBus David Vrabel
     [not found]   ` <52AAE7D8.2030602@citrix.com>
2013-12-13 14:26     ` Konrad Rzeszutek Wilk
     [not found]     ` <20131213142651.GD2923@phenom.dumpdata.com>
2013-12-13 14:59       ` Stefano Stabellini
2013-12-13 11:37 ` [PATCH v10] Repost of PVH patches for Linux David Vrabel
     [not found] ` <52AAF176.3020102@citrix.com>
2013-12-13 14:30   ` Konrad Rzeszutek Wilk
     [not found] ` <1386900621-27528-4-git-send-email-konrad.wilk@oracle.com>
2013-12-13 16:54   ` [PATCH V10 03/14] xen/pvh: Implement MMU changes for PVH Boris Ostrovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386900621-27528-9-git-send-email-konrad.wilk@oracle.com \
    --to=konrad@kernel.org \
    --cc=alexander.h.duyck@intel.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.rathor@oracle.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).