From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH 02/13 v2] libxl: check for xc_domain_setmaxmem failure in libxl__build_pre Date: Fri, 13 Dec 2013 11:17:47 +0100 Message-ID: <1386929867.1413.28.camel@Abyss> References: <21148.30016.686515.468200@mariner.uk.xensource.com> <1385986303-30544-1-git-send-email-mattd@bugfuzz.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3410764547358602289==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Matthew Daley Cc: Andrew Cooper , Stefano Stabellini , Ian Jackson , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org --===============3410764547358602289== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-rVGVQsFogkA6DF9+EDEz" --=-rVGVQsFogkA6DF9+EDEz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On ven, 2013-12-13 at 18:53 +1300, Matthew Daley wrote: > Ping? >=20 > On Tue, Dec 3, 2013 at 1:11 AM, Matthew Daley wrote: > > Coverity-ID: 1087115 > > Signed-off-by: Matthew Daley > Reviewed-by: Dario Faggioli Regards, Dario > > --- > > v2: Use LIBXL__LOG_ERRNO instead of LOG and return ERROR_FAIL instead o= f -1 > > > > tools/libxl/libxl_dom.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > > index e95eff8..e696fee 100644 > > --- a/tools/libxl/libxl_dom.c > > +++ b/tools/libxl/libxl_dom.c > > @@ -224,7 +224,6 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid, > > * whatever that turns out to be. > > */ > > if (libxl_defbool_val(info->numa_placement)) { > > - > > if (!libxl_bitmap_is_full(&info->cpumap)) { > > LOG(ERROR, "Can run NUMA placement only if no vcpu " > > "affinity is specified"); > > @@ -238,7 +237,12 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid= , > > libxl_domain_set_nodeaffinity(ctx, domid, &info->nodemap); > > libxl_set_vcpuaffinity_all(ctx, domid, info->max_vcpus, &info->cpu= map); > > > > - xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + LIBXL_MA= XMEM_CONSTANT); > > + if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + > > + LIBXL_MAXMEM_CONSTANT) < 0) { > > + LIBXL__LOG_ERRNO(ctx, LIBXL__LOG_ERROR, "Couldn't set max memo= ry"); > > + return ERROR_FAIL; > > + } > > + > > xs_domid =3D xs_read(ctx->xsh, XBT_NULL, "/tool/xenstored/domid", = NULL); > > state->store_domid =3D xs_domid ? atoi(xs_domid) : 0; > > free(xs_domid); > > -- > > 1.7.10.4 > > >=20 > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-rVGVQsFogkA6DF9+EDEz Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iEYEABECAAYFAlKq3ssACgkQk4XaBE3IOsQ8kgCff97/tNx950SRrathRkJqVHVJ k34AnRXhoYnDNeFzYbMMF/+u0ftWVfNy =9gqL -----END PGP SIGNATURE----- --=-rVGVQsFogkA6DF9+EDEz-- --===============3410764547358602289== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3410764547358602289==--