From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: stefano.stabellini@citrix.com,
Julien Grall <julien.grall@linaro.org>,
tim@xen.org, ian.campbell@citrix.com, patches@linaro.org
Subject: [PATCH v5 02/10] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c
Date: Mon, 16 Dec 2013 17:37:24 +0000 [thread overview]
Message-ID: <1387215452-10951-3-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1387215452-10951-1-git-send-email-julien.grall@linaro.org>
The function mfn_to_p2m_entry will be extended in a following patch to handle
p2m_type_t. It will break compilation because p2m_type_t is not defined
(interdependence between includes).
It's easier to move the function in arch/arm/p2m.c and it's not harmful as the
function is only used in this file.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
---
xen/arch/arm/p2m.c | 22 ++++++++++++++++++++++
xen/include/asm-arm/page.h | 22 ----------------------
2 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 083f8bf..74636df 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -128,6 +128,28 @@ int p2m_pod_decrease_reservation(struct domain *d,
return -ENOSYS;
}
+static lpae_t mfn_to_p2m_entry(unsigned long mfn, unsigned int mattr)
+{
+ paddr_t pa = ((paddr_t) mfn) << PAGE_SHIFT;
+ lpae_t e = (lpae_t) {
+ .p2m.xn = 0,
+ .p2m.af = 1,
+ .p2m.sh = LPAE_SH_OUTER,
+ .p2m.read = 1,
+ .p2m.write = 1,
+ .p2m.mattr = mattr,
+ .p2m.table = 1,
+ .p2m.valid = 1,
+ };
+
+ ASSERT(!(pa & ~PAGE_MASK));
+ ASSERT(!(pa & ~PADDR_MASK));
+
+ e.bits |= pa;
+
+ return e;
+}
+
/* Allocate a new page table page and hook it in via the given entry */
static int p2m_create_table(struct domain *d,
lpae_t *entry)
diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h
index d468418..0625464 100644
--- a/xen/include/asm-arm/page.h
+++ b/xen/include/asm-arm/page.h
@@ -213,28 +213,6 @@ static inline lpae_t mfn_to_xen_entry(unsigned long mfn)
return e;
}
-static inline lpae_t mfn_to_p2m_entry(unsigned long mfn, unsigned int mattr)
-{
- paddr_t pa = ((paddr_t) mfn) << PAGE_SHIFT;
- lpae_t e = (lpae_t) {
- .p2m.xn = 0,
- .p2m.af = 1,
- .p2m.sh = LPAE_SH_OUTER,
- .p2m.write = 1,
- .p2m.read = 1,
- .p2m.mattr = mattr,
- .p2m.table = 1,
- .p2m.valid = 1,
- };
-
- ASSERT(!(pa & ~PAGE_MASK));
- ASSERT(!(pa & ~PADDR_MASK));
-
- e.bits |= pa;
-
- return e;
-}
-
#if defined(CONFIG_ARM_32)
# include <asm/arm32/page.h>
#elif defined(CONFIG_ARM_64)
--
1.7.10.4
next prev parent reply other threads:[~2013-12-16 17:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 17:37 [PATCH v5 00/10] xen/arm: Handle correctly foreign mapping Julien Grall
2013-12-16 17:37 ` [PATCH v5 01/10] xen/arm: Introduce steps in domain_relinquish_resource Julien Grall
2013-12-16 17:37 ` Julien Grall [this message]
2013-12-16 17:37 ` [PATCH v5 03/10] xen/arm: Implement p2m_type_t as an enum Julien Grall
2013-12-16 17:37 ` [PATCH v5 04/10] xen/arm: Store p2m type in each page of the guest Julien Grall
2013-12-16 17:49 ` Ian Campbell
2013-12-16 22:54 ` Julien Grall
2013-12-16 17:37 ` [PATCH v5 05/10] xen/arm: p2m: Extend p2m_lookup parameters to retrieve the p2m type Julien Grall
2013-12-17 11:12 ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 06/10] xen/arm: Retrieve p2m type in get_page_from_gfn Julien Grall
2013-12-17 11:13 ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 07/10] xen/arm: Handle remove foreign mapping Julien Grall
2013-12-17 11:18 ` Ian Campbell
2013-12-17 15:06 ` Julien Grall
2013-12-17 15:21 ` Ian Campbell
2013-12-17 15:44 ` Julien Grall
2013-12-17 15:45 ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page Julien Grall
2013-12-17 9:26 ` Ian Campbell
2013-12-17 10:03 ` Jan Beulich
2013-12-17 10:12 ` Ian Campbell
2013-12-17 14:08 ` Julien Grall
2013-12-17 14:13 ` Ian Campbell
2013-12-17 14:40 ` Julien Grall
2013-12-17 14:42 ` Ian Campbell
2013-12-17 14:45 ` Julien Grall
2013-12-17 14:52 ` Ian Campbell
2013-12-17 14:57 ` Julien Grall
2013-12-17 11:31 ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 09/10] xen/arm: Set foreign page type to p2m_map_foreign Julien Grall
2013-12-17 11:34 ` Ian Campbell
2013-12-16 17:37 ` [PATCH v5 10/10] xen/arm: grant-table: Support read-only mapping Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387215452-10951-3-git-send-email-julien.grall@linaro.org \
--to=julien.grall@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=patches@linaro.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).