xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Julien Grall <julien.grall@linaro.org>,
	ian.jackson@eu.citrix.com, ian.campbell@citrix.com,
	patches@linaro.org
Subject: [PATCH v6 06/10] xen/arm: Retrieve p2m type in get_page_from_gfn
Date: Tue, 17 Dec 2013 16:27:54 +0000	[thread overview]
Message-ID: <1387297678-17762-7-git-send-email-julien.grall@linaro.org> (raw)
In-Reply-To: <1387297678-17762-1-git-send-email-julien.grall@linaro.org>

Signed-off-by: Julien Grall <julien.grall@linaro.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>

---
    Changes in v3:
        - Return NULL when p2m type is invalid or mmio
    Changes in v2:
        - Use p2m_lookup as p2m_get_entry was removed
---
 xen/include/asm-arm/p2m.h |   12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/xen/include/asm-arm/p2m.h b/xen/include/asm-arm/p2m.h
index 9d0d1e7..0eb07a8 100644
--- a/xen/include/asm-arm/p2m.h
+++ b/xen/include/asm-arm/p2m.h
@@ -109,11 +109,17 @@ static inline struct page_info *get_page_from_gfn(
     struct domain *d, unsigned long gfn, p2m_type_t *t, p2m_query_t q)
 {
     struct page_info *page;
-    unsigned long mfn = gmfn_to_mfn(d, gfn);
+    p2m_type_t p2mt;
+    paddr_t maddr = p2m_lookup(d, pfn_to_paddr(gfn), &p2mt);
+    unsigned long mfn = maddr >> PAGE_SHIFT;
 
-    ASSERT(t == NULL);
+    if (t)
+        *t = p2mt;
 
-    if (!mfn_valid(mfn))
+    if ( p2mt == p2m_invalid || p2mt == p2m_mmio_direct )
+        return NULL;
+
+    if ( !mfn_valid(mfn) )
         return NULL;
     page = mfn_to_page(mfn);
     if ( !get_page(page, d) )
-- 
1.7.10.4

  parent reply	other threads:[~2013-12-17 16:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17 16:27 [PATCH v6 00/10] xen/arm: Handle correctly foreign mapping Julien Grall
2013-12-17 16:27 ` [PATCH v6 01/10] xen/arm: Introduce steps in domain_relinquish_resource Julien Grall
2013-12-17 16:27 ` [PATCH v6 02/10] xen/arm: move mfn_to_p2m_entry in arch/arm/p2m.c Julien Grall
2013-12-17 16:27 ` [PATCH v6 03/10] xen/arm: Implement p2m_type_t as an enum Julien Grall
2013-12-17 16:27 ` [PATCH v6 04/10] xen/arm: Store p2m type in each page of the guest Julien Grall
2013-12-18 14:18   ` Ian Campbell
2013-12-17 16:27 ` [PATCH v6 05/10] xen/arm: p2m: Extend p2m_lookup parameters to retrieve the p2m type Julien Grall
2013-12-17 16:27 ` Julien Grall [this message]
2013-12-17 16:27 ` [PATCH v6 07/10] xen/arm: Handle remove foreign mapping Julien Grall
2013-12-17 16:27 ` [PATCH v6 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page Julien Grall
2013-12-17 16:36   ` Ian Campbell
2013-12-17 16:58     ` Julien Grall
2013-12-17 17:02       ` Ian Campbell
2013-12-18 13:21         ` Ian Campbell
2013-12-18 13:30           ` Julien Grall
2013-12-18 14:06           ` Julien Grall
2013-12-18 14:12             ` Ian Campbell
2013-12-18 14:20   ` Ian Campbell
2013-12-18 16:48   ` Julien Grall
2013-12-18 16:50     ` Ian Campbell
2013-12-17 16:27 ` [PATCH v6 09/10] xen/arm: Set foreign page type to p2m_map_foreign Julien Grall
2013-12-17 16:27 ` [PATCH v6 10/10] xen/arm: grant-table: Support read-only mapping Julien Grall
2013-12-18 14:41 ` [PATCH v6 00/10] xen/arm: Handle correctly foreign mapping Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1387297678-17762-7-git-send-email-julien.grall@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=patches@linaro.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).