From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v6 08/10] xen/arm: Add relinquish_p2m_mapping to remove reference on every mapped page Date: Tue, 17 Dec 2013 16:36:57 +0000 Message-ID: <1387298217.1025.5.camel@dagon.hellion.org.uk> References: <1387297678-17762-1-git-send-email-julien.grall@linaro.org> <1387297678-17762-9-git-send-email-julien.grall@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VsxeB-0007SC-H6 for xen-devel@lists.xenproject.org; Tue, 17 Dec 2013 16:37:27 +0000 In-Reply-To: <1387297678-17762-9-git-send-email-julien.grall@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com, patches@linaro.org List-Id: xen-devel@lists.xenproject.org On Tue, 2013-12-17 at 16:27 +0000, Julien Grall wrote: > This function will be called when the domain relinquishes its memory. > It removes refcount on every mapped page to a valid MFN. > > Currently, Xen doesn't take reference on every new mapping but only for foreign > mapping. Restrict the function only on foreign mapping. > > Signed-off-by: Julien Grall > > --- > Changes in v6: > - Typoes > - Rework preempt > - Clean up if ( p2mt == ... || p2mt == ... ) You don't seem to have addressed the issue I pointed out about create_p2m_entries exiting on any holes which it finds at the first or second level. I think you missed my second reply to 08/10 on v5 see: <1387279904.27441.47.camel@kazak.uk.xensource.com> Ian.