From: Dario Faggioli <dario.faggioli@citrix.com>
To: Justin Weaver <jtweaver@hawaii.edu>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
Marcus.Granado@eu.citrix.com, xen-devel@lists.xen.org,
Henri Casanova <henric@hawaii.edu>
Subject: Re: [PATCH v2] xen: sched: introduce hard and soft affinity in credit 2 scheduler
Date: Fri, 17 Jan 2014 23:18:46 +0100 [thread overview]
Message-ID: <1389997126.16457.339.camel@Solace> (raw)
In-Reply-To: <CA+o8iRXZgH37gM1i5Z5+wkU1dpHvDRML1TiwgfRuZRCcuKsadg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1962 bytes --]
On gio, 2014-01-16 at 10:23 -1000, Justin Weaver wrote:
> Dario,
>
Hey! :-)
> Sorry for disappearing for so long ... I'm back and ready to continue working.
>
NP at all.
> Other functions will need to change, but currently with only one run
> queue, only runq_candidate needed to change. I'll look through the
> others again with the mindset that we (or maybe I) will fix the issue
> that is causing only one run queue to be created despite having
> multiple cores/sockets available.
>
> >> Function now chooses the vCPU with the most credit that has hard affinity
> >> and maybe soft affinity for the given pCPU. If it does not have soft affinity
> >> and there is another vCPU that prefers to run on the given pCPU, then as long
> >> as it has at least a certain amount of credit (currently defined as half of
> >> CSCHED_CREDIT_INIT, but more testing is needed to determine the best value)
> >> then it is chosen instead.
> >>
> > Ok, so, why this 'certain amount of credit' thing? I got the technical
> > details of it from the code below, but can you spend a few words on why
> > and how you think something like this would be required and/or useful?
>
Allow me to comment only on the 'only one runqueue on multiple socket
issue' thing. I honestly think that that one is a bug, so you shouldn't
base your work on that behavior. To try facilitate you doing this, I'll
try to put together a patch for fixing such issue early next week. I'm
not sure wheter it will be accepted in Xen right now or when 4.5
development cycle opens, but at least you can apply that and work on top
of it.
Would that make sense and be of any help to you?
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-01-17 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-14 18:15 [PATCH v2] xen: sched: introduce hard and soft affinity in credit 2 scheduler Justin Weaver
2013-12-18 2:37 ` Dario Faggioli
2014-01-16 20:23 ` Justin Weaver
2014-01-17 22:18 ` Dario Faggioli [this message]
2014-01-21 1:02 ` Justin Weaver
2014-01-21 8:52 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389997126.16457.339.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Marcus.Granado@eu.citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=henric@hawaii.edu \
--cc=jtweaver@hawaii.edu \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).