From: Mukesh Rathor <mukesh.rathor@oracle.com>
To: Xen-devel@lists.xensource.com
Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
ian.campbell@citrix.com, roger.pau@citrix.com
Subject: [V0 PATCH] pvh: expose feature flags from tools for domUs
Date: Fri, 24 Jan 2014 17:13:30 -0800 [thread overview]
Message-ID: <1390612410-27384-2-git-send-email-mukesh.rathor@oracle.com> (raw)
In-Reply-To: <1390612410-27384-1-git-send-email-mukesh.rathor@oracle.com>
Expose features for pvh domUs from tools.
Signed-off-by: Mukesh Rathor <mukesh.rathor@oracle.com>
---
tools/libxc/xc_cpuid_x86.c | 26 ++++++++++++++++----------
tools/libxc/xc_domain.c | 1 +
tools/libxc/xenctrl.h | 2 +-
3 files changed, 18 insertions(+), 11 deletions(-)
diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
index bbbf9b8..33f6829 100644
--- a/tools/libxc/xc_cpuid_x86.c
+++ b/tools/libxc/xc_cpuid_x86.c
@@ -433,7 +433,7 @@ static void xc_cpuid_hvm_policy(
static void xc_cpuid_pv_policy(
xc_interface *xch, domid_t domid,
- const unsigned int *input, unsigned int *regs)
+ const unsigned int *input, unsigned int *regs, int is_pvh)
{
DECLARE_DOMCTL;
unsigned int guest_width;
@@ -455,13 +455,16 @@ static void xc_cpuid_pv_policy(
if ( (input[0] & 0x7fffffff) == 0x00000001 )
{
- clear_bit(X86_FEATURE_VME, regs[3]);
- clear_bit(X86_FEATURE_PSE, regs[3]);
- clear_bit(X86_FEATURE_PGE, regs[3]);
- clear_bit(X86_FEATURE_MCE, regs[3]);
- clear_bit(X86_FEATURE_MCA, regs[3]);
+ if ( !is_pvh )
+ {
+ clear_bit(X86_FEATURE_VME, regs[3]);
+ clear_bit(X86_FEATURE_PSE, regs[3]);
+ clear_bit(X86_FEATURE_PGE, regs[3]);
+ clear_bit(X86_FEATURE_MCE, regs[3]);
+ clear_bit(X86_FEATURE_MCA, regs[3]);
+ clear_bit(X86_FEATURE_PSE36, regs[3]);
+ }
clear_bit(X86_FEATURE_MTRR, regs[3]);
- clear_bit(X86_FEATURE_PSE36, regs[3]);
}
switch ( input[0] )
@@ -524,8 +527,11 @@ static void xc_cpuid_pv_policy(
{
set_bit(X86_FEATURE_SYSCALL, regs[3]);
}
- clear_bit(X86_FEATURE_PAGE1GB, regs[3]);
- clear_bit(X86_FEATURE_RDTSCP, regs[3]);
+ if ( !is_pvh )
+ {
+ clear_bit(X86_FEATURE_PAGE1GB, regs[3]);
+ clear_bit(X86_FEATURE_RDTSCP, regs[3]);
+ }
clear_bit(X86_FEATURE_SVM, regs[2]);
clear_bit(X86_FEATURE_OSVW, regs[2]);
@@ -561,7 +567,7 @@ static int xc_cpuid_policy(
if ( info.hvm )
xc_cpuid_hvm_policy(xch, domid, input, regs);
else
- xc_cpuid_pv_policy(xch, domid, input, regs);
+ xc_cpuid_pv_policy(xch, domid, input, regs, info.pvh);
return 0;
}
diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c
index c2fdd74..f12999a 100644
--- a/tools/libxc/xc_domain.c
+++ b/tools/libxc/xc_domain.c
@@ -316,6 +316,7 @@ int xc_domain_getinfo(xc_interface *xch,
info->running = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_running);
info->hvm = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_hvm_guest);
info->debugged = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_debugged);
+ info->pvh = !!(domctl.u.getdomaininfo.flags&XEN_DOMINF_pvh_guest);
info->shutdown_reason =
(domctl.u.getdomaininfo.flags>>XEN_DOMINF_shutdownshift) &
diff --git a/tools/libxc/xenctrl.h b/tools/libxc/xenctrl.h
index 13f816b..77d219a 100644
--- a/tools/libxc/xenctrl.h
+++ b/tools/libxc/xenctrl.h
@@ -404,7 +404,7 @@ typedef struct xc_dominfo {
uint32_t ssidref;
unsigned int dying:1, crashed:1, shutdown:1,
paused:1, blocked:1, running:1,
- hvm:1, debugged:1;
+ hvm:1, debugged:1, pvh:1;
unsigned int shutdown_reason; /* only meaningful if shutdown==1 */
unsigned long nr_pages; /* current number, not maximum */
unsigned long nr_outstanding_pages;
--
1.7.2.3
next prev parent reply other threads:[~2014-01-25 1:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 1:13 [V0 PATCH]: feature flags for PVH Mukesh Rathor
2014-01-25 1:13 ` Mukesh Rathor [this message]
2014-01-28 11:14 ` [V0 PATCH] pvh: expose feature flags from tools for domUs Ian Campbell
2014-01-29 2:31 ` Mukesh Rathor
2014-01-28 12:24 ` Roger Pau Monné
2014-01-28 12:37 ` Jan Beulich
2014-01-29 2:33 ` Mukesh Rathor
2014-02-07 1:15 ` Mukesh Rathor
2014-02-07 9:54 ` Ian Campbell
2014-02-07 8:41 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1390612410-27384-2-git-send-email-mukesh.rathor@oracle.com \
--to=mukesh.rathor@oracle.com \
--cc=Xen-devel@lists.xensource.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).