From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [Xen-devel Patch 0/2] Prevent xc_domain_restore() returning success despite errors Date: Mon, 27 Jan 2014 16:25:23 +0000 Message-ID: <1390839925-28088-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: George Dunlap , Andrew Cooper , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org When looking through the XenServer patch queue, I noticed two bugfixes which really should make their way upstream. Both of these errors have been discovered by xc_domain_restore() returning success after suffering a fatal error during migration, leading to the toolstack believing that the VM migrated successfully. Regarding 4.4: I know this is quite late in the 4.4 cycle, and I apologise for not noticing and upstreaming earlier, but I believe that these two fixes should be considered for inclusion into 4.4. They are both real errors found by XenRT causing mismanagement of migrated domains. Both patches are small, concise, and (I believe) well explained. The the use of various '*rc' variables can be easily viewed using `grep "rc " xc_domain_restore.c`. The risks are that I have made a mistake which could result in further migration errors. However, that risk is mitigated by functionally-similar fixes being present in XenServer, and hopefully from the obvious nature of the patches. Futhermore, the changes themselves are for error paths. On the other hand, if they are deemed too risky (or buggy given review), it will not be the end of the world if not included, although I hope that is not the case. Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: George Dunlap -- 1.7.10.4