From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 03/18] libxl: fork: Clarify docs for libxl_sigchld_owner Date: Mon, 3 Feb 2014 16:14:36 +0000 Message-ID: <1391444091-22796-4-git-send-email-ian.jackson@eu.citrix.com> References: <1391444091-22796-1-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1391444091-22796-1-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xensource.com Cc: George Dunlap , Jim Fehlig , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org Clarify that libxl_sigchld_owner_libxl causes libxl to reap all the process's children, and clarify the wording of the description of libxl_sigchld_owner_libxl_always. Signed-off-by: Ian Jackson Cc: Jim Fehlig Cc: Ian Campbell Acked-by: Ian Campbell --- tools/libxl/libxl_event.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/libxl/libxl_event.h b/tools/libxl/libxl_event.h index 6261f99..ff0b2fa 100644 --- a/tools/libxl/libxl_event.h +++ b/tools/libxl/libxl_event.h @@ -467,7 +467,8 @@ void libxl_osevent_occurred_timeout(libxl_ctx *ctx, void *for_libxl) typedef enum { - /* libxl owns SIGCHLD whenever it has a child. */ + /* libxl owns SIGCHLD whenever it has a child, and reaps + * all children, including those not spawned by libxl. */ libxl_sigchld_owner_libxl, /* Application promises to call libxl_childproc_exited but NOT @@ -476,7 +477,7 @@ typedef enum { libxl_sigchld_owner_mainloop, /* libxl owns SIGCHLD all the time, and the application is - * relying on libxl's event loop for reaping its own children. */ + * relying on libxl's event loop for reaping its children too. */ libxl_sigchld_owner_libxl_always, } libxl_sigchld_owner; -- 1.7.10.4