xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: jbeulich@suse.com, george.dunlap@eu.citrix.com,
	xen-devel@lists.xenproject.org, jun.nakajima@intel.com,
	mukesh.rathor@oracle.com, yang.z.zhang@Intel.com
Subject: [PATCH] pvh: Fix regression caused by assumption that HVM paths MUST use io-backend device.
Date: Mon,  3 Feb 2014 12:03:21 -0500	[thread overview]
Message-ID: <1391447001-19100-2-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1391447001-19100-1-git-send-email-konrad.wilk@oracle.com>

The commit 09bb434748af9bfe3f7fca4b6eef721a7d5042a4
"Nested VMX: prohibit virtual vmentry/vmexit during IO emulation"
assumes that the HVM paths are only taken by HVM guests. With the PVH
enabled that is no longer the case - which means that we do not have
to have the IO-backend device (QEMU) enabled.

As such, that patch can crash the hypervisor:

Xen call trace:
    [<ffff82d0801ddd9a>] nvmx_switch_guest+0x4d/0x903
    [<ffff82d0801de95b>] vmx_asm_vmexit_handler+0x4b/0xc0

Pagetable walk from 000000000000001e:
  L4[0x000] = 0000000000000000 ffffffffffffffff

****************************************
Panic on CPU 7:
FATAL PAGE FAULT
[error_code=0000]
Faulting linear address: 000000000000001e
****************************************

as we do not have an io based backend.

CC: Yang Zhang <yang.z.zhang@Intel.com>
CC: Jun Nakajima <jun.nakajima@intel.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen/arch/x86/hvm/vmx/vvmx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c
index d2ba435..2f516c9 100644
--- a/xen/arch/x86/hvm/vmx/vvmx.c
+++ b/xen/arch/x86/hvm/vmx/vvmx.c
@@ -1400,7 +1400,7 @@ void nvmx_switch_guest(void)
      * no virtual vmswith is allowed. Or else, the following IO
      * emulation will handled in a wrong VCPU context.
      */
-    if ( get_ioreq(v)->state != STATE_IOREQ_NONE )
+    if ( get_ioreq(v) && get_ioreq(v)->state != STATE_IOREQ_NONE )
         return;
     /*
      * a softirq may interrupt us between a virtual vmentry is
-- 
1.7.7.6

  reply	other threads:[~2014-02-03 17:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-03 17:03 [PATCH] Xen 4.4-rc3 regression with PVH compared to Xen 4.4-rc2 Konrad Rzeszutek Wilk
2014-02-03 17:03 ` Konrad Rzeszutek Wilk [this message]
2014-02-04  8:54   ` [PATCH] pvh: Fix regression caused by assumption that HVM paths MUST use io-backend device Jan Beulich
2014-02-04 14:48     ` Konrad Rzeszutek Wilk
2014-02-04 15:02       ` Jan Beulich
2014-02-04 15:32         ` Konrad Rzeszutek Wilk
2014-02-04 15:46           ` Jan Beulich
2014-02-04 16:42             ` Konrad Rzeszutek Wilk
2014-02-05 14:35               ` George Dunlap
2014-02-05 15:00                 ` Jan Beulich
2014-02-05 15:26                 ` Konrad Rzeszutek Wilk
2014-02-07  2:28                   ` Zhang, Yang Z
2014-02-07 15:41                     ` Konrad Rzeszutek Wilk
2014-02-10 12:40                       ` George Dunlap
2014-02-11  0:17                       ` Zhang, Yang Z
2014-02-13 15:38                         ` George Dunlap
2014-02-13 16:03                           ` Jan Beulich
2014-02-13 16:08                             ` George Dunlap
2014-02-13 17:00                               ` Jan Beulich
2014-02-03 19:26 ` [PATCH] Xen 4.4-rc3 regression with PVH compared to Xen 4.4-rc2 Mukesh Rathor
2014-02-03 19:53   ` Konrad Rzeszutek Wilk
2014-02-03 20:01     ` Mukesh Rathor
2014-02-04  1:16   ` Mukesh Rathor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391447001-19100-2-git-send-email-konrad.wilk@oracle.com \
    --to=konrad@kernel.org \
    --cc=george.dunlap@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=jun.nakajima@intel.com \
    --cc=mukesh.rathor@oracle.com \
    --cc=xen-devel@lists.xenproject.org \
    --cc=yang.z.zhang@Intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).