From: Dario Faggioli <dario.faggioli@citrix.com>
To: Juergen Gross <juergen.gross@ts.fujitsu.com>
Cc: Marcus.Granado@eu.citrix.com, Justin Weaver <jtweaver@hawaii.edu>,
george.dunlap@eu.citrix.com, esb@ics.hawaii.edu,
xen-devel@lists.xen.org, henric@hawaii.edu
Subject: Re: [PATCH] Xen sched: Fix multiple runqueues in credit2
Date: Thu, 6 Feb 2014 14:57:52 +0100 [thread overview]
Message-ID: <1391695072.9917.13.camel@Solace> (raw)
In-Reply-To: <52F393F8.8010206@ts.fujitsu.com>
[-- Attachment #1.1: Type: text/plain, Size: 1064 bytes --]
On gio, 2014-02-06 at 14:54 +0100, Juergen Gross wrote:
> On 06.02.2014 14:44, Dario Faggioli wrote:
> > My point being that, Justing is trying to fix a bug in credit2, which
> > says it constructs one runqueue per socket, while it ends up with only
> > one runqueue at all. If there is another bug, or buggy behavior, wrt how
> > this interacts with cpupools, although we should fix that too, that's
> > pre-existent and needs addressing in a dedicated patch (series), isn't
> > it?
>
> Now it will construct one runqueue per cpupool. There is one sched_private
> structure per cpupool!
>
> I'm not sure what will happen with the change proposed by Justin in case of
> multiple credit2 cpupools...
>
I see... Mmm, let me try to think a bit more about this then.
Thanks,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-02-06 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 8:58 [PATCH] Xen sched: Fix multiple runqueues in credit2 Justin Weaver
2014-02-06 9:13 ` Juergen Gross
2014-02-06 13:44 ` Dario Faggioli
2014-02-06 13:54 ` Juergen Gross
2014-02-06 13:57 ` Dario Faggioli [this message]
2014-02-06 11:17 ` Jan Beulich
2014-02-06 14:20 ` Dario Faggioli
2014-02-08 7:37 ` Justin Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391695072.9917.13.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Marcus.Granado@eu.citrix.com \
--cc=esb@ics.hawaii.edu \
--cc=george.dunlap@eu.citrix.com \
--cc=henric@hawaii.edu \
--cc=jtweaver@hawaii.edu \
--cc=juergen.gross@ts.fujitsu.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).