From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: [BUGFIX][PATCH 0/1] Enable 4.4 to build on CentOS/RHEL
	5.10
Date: Fri,  7 Feb 2014 16:51:50 -0500
Message-ID: <1391809911-13610-1-git-send-email-dslutz@verizon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xen.org
Cc: David Scott <dave.scott@eu.citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <george.dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Don Slutz <dslutz@verizon.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

I only did Andrew Cooper's statement of "Applying the top macro".
There is no checking of ocaml version.

Since CentOS/RHEL 5.10 (Released on 22-Oct-2013) disto provides
ocaml 3.09.3, the current code does not build.

Compile tested and simple tests done on CentOS 5.10 and Fedora 17.

Note: The formating of the code was changed to be closer to "Coding
Style for the Xen Hypervisor".  The file has a non-standard emacs
setting at the end (indent of 8 and use tabs).  And the example of
code just below was not used as an example of coding style to
follow do to lack of indent at all.

I feel this should have a release exception and go into 4.4 for 2
reasons:

1) It is a bufix for CentOS/RHEL 5.10 and looks to be low risk.

2) It make the release more awesome to run on these distros.


"What functionality is being fixed / enabled by this patch?"

4.4 Added CAML_returnT usage.  ocaml provided this at 3.09.4.


"If there was a bug in this patch, what functionality might be broken?"

ocaml may stop functioning.  Since this is conditional code, ocaml
should only possibly have issues on CentOS/RHEL 5.10.


"What is the probability that this patch has a bug?"

I feel it is low.

Mail thread:

http://lists.xen.org/archives/html/xen-devel/2014-02/msg00665.html

Don Slutz (1):
  xenlight_stubs.c: Allow it to build with ocaml 3.09.3

 tools/ocaml/libs/xl/xenlight_stubs.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
1.8.4