From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v3] Xen sched: Fix multiple runqueues in
 credit2
Date: Mon, 10 Feb 2014 10:52:26 +0100
Message-ID: <1392025946.12373.22.camel@Abyss>
References: <1391911066-2572-1-git-send-email-jtweaver@hawaii.edu>
	<52F8A15A020000780011A9E2@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7555661680099232760=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <52F8A15A020000780011A9E2@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Marcus.Granado@eu.citrix.com, Justin Weaver <jtweaver@hawaii.edu>, george.dunlap@eu.citrix.com, juergen.gross@ts.fujitsu.com, esb@ics.hawaii.edu, xen-devel@lists.xen.org, henric@hawaii.edu
List-Id: xen-devel@lists.xenproject.org

--===============7555661680099232760==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-FVdf3VovzcPNGLtzvkNG"

--=-FVdf3VovzcPNGLtzvkNG
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2014-02-10 at 08:52 +0000, Jan Beulich wrote:
> >>> On 09.02.14 at 02:57, Justin Weaver <jtweaver@hawaii.edu> wrote:
> > @@ -1959,15 +1961,25 @@ static void init_pcpu(const struct scheduler *o=
ps, int cpu)
> >          return;
> >      }
> > =20
> > -    /* Figure out which runqueue to put it in */
> > +    /*
> > +     * Choose which run queue to add cpu to based on its socket.
> > +     * If it's CPU 0, hard code it to run queue 0 (it doesn't get a ST=
ARTING
> > +     * callback and socket information is not yet available for it).
>=20
> Did you verify that last part to be the case? Because if so, we would
> probably be better off fixing the initialization ordering.
>=20
Last part =3D=3D "socket information is not yet available" ? If yes, yes, a=
t
least on my system, cpu_to_socket() always return 0 (or, if I statically
initialize the array to -1, it always return -1) at that time, and I
have CPU0 on socket 1, so I'm quite sure that is the case.

By fixing the init order, do you mean moving whatever does the
cpu-to-socket mapping before scheduler's initialization?

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-FVdf3VovzcPNGLtzvkNG
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEABECAAYFAlL4oVoACgkQk4XaBE3IOsTjuQCcDE0rhFPaRpP6d4ivhRadFoEk
i+0An1INJIiAbDxZxgqL1bYWn9PVtyyQ
=psPA
-----END PGP SIGNATURE-----

--=-FVdf3VovzcPNGLtzvkNG--


--===============7555661680099232760==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============7555661680099232760==--