xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: xen-devel@lists.xenproject.org
Cc: Ian.Jackson@eu.citrix.com, keir@xen.org, tim@xen.org,
	ian.campbell@citrix.com, Julien Grall <julien.grall@linaro.org>
Subject: [PATCH] xen: Don't use -nostdinc flags with CLANG
Date: Mon, 10 Feb 2014 23:29:34 +0000	[thread overview]
Message-ID: <1392074974-1488-1-git-send-email-julien.grall@linaro.org> (raw)

Commit 06a9c7e "xen: move -nostdinc into common Rules.mk." breaks
compilation with clang:

In file included from sched_sedf.c:8:
In file included from /home/julieng/works/xen/xen/include/xen/lib.h:5:
/home/julieng/works/xen/xen/include/xen/stdarg.h:20:12: error: 'stdarg.h' file
not found with <angled> include; use "quotes" instead
           ^~~~~~~~~~
           "stdarg.h"
In file included from sched_sedf.c:8:
/home/julieng/works/xen/xen/include/xen/lib.h:101:63: error: unknown type name 'va_list'
extern int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
                                                              ^
/home/julieng/works/xen/xen/include/xen/lib.h:105:64: error: unknown type name 'va_list'
extern int vscnprintf(char *buf, size_t size, const char *fmt, va_list args)

I have the same errors on different version of clang:
    - clang 3.0 on debian wheezy
    - clang 3.3 on Fedora 20
    - clang 3.5 build from trunk

Removing -nostdinc fix the build on clang.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/Rules.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/xen/Rules.mk b/xen/Rules.mk
index df1428f..ed9b8d0 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -46,7 +46,8 @@ CFLAGS += -Werror -Wredundant-decls -Wno-pointer-arith
 CFLAGS += -pipe -g -D__XEN__ -include $(BASEDIR)/include/xen/config.h
 # Solaris puts stdarg.h &c in the system include directory.
 ifneq ($(XEN_OS),SunOS)
-CFLAGS += -nostdinc -iwithprefix include
+CFLAGS-y        += -iwithprefix include
+CFLAGS-$(gcc)   += -nostdinc
 endif
 
 CFLAGS-$(XSM_ENABLE)    += -DXSM_ENABLE
-- 
1.8.5.3

             reply	other threads:[~2014-02-10 23:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-10 23:29 Julien Grall [this message]
2014-02-11  8:37 ` [PATCH] xen: Don't use -nostdinc flags with CLANG Jan Beulich
2014-02-11  8:53 ` Tim Deegan
2014-02-11 12:30   ` Julien Grall
2014-02-11 12:35     ` Tim Deegan
2014-02-11 12:36       ` Julien Grall
2014-02-11 12:59         ` Tim Deegan
2014-02-11 13:20           ` Julien Grall
2014-02-11 13:59             ` Tim Deegan
2014-02-11 14:24               ` Julien Grall
2014-02-11 14:33                 ` Tim Deegan
2014-02-11 15:01                   ` Keir Fraser
2014-02-13 11:24                   ` Tim Deegan
2014-02-13 11:46                     ` George Dunlap
2014-02-13 11:49                       ` George Dunlap
2014-02-13 15:19                   ` [PATCH] xen: Don't use __builtin_stdarg_start() Tim Deegan
2014-02-13 15:22                     ` George Dunlap
2014-02-13 15:32                     ` Roger Pau Monné
2014-02-11 13:21           ` [PATCH] xen: Don't use -nostdinc flags with CLANG Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392074974-1488-1-git-send-email-julien.grall@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).