xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: ian.jackson@eu.citrix.com
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
Subject: [PATCH OSSTEST 1/2] Revert "mfi-common: Only override the pvops kernel repo for linux-arm-xen branch"
Date: Tue, 11 Feb 2014 12:41:59 +0000	[thread overview]
Message-ID: <1392122520-5453-1-git-send-email-ian.campbell@citrix.com> (raw)
In-Reply-To: <1392122393.26657.102.camel@kazak.uk.xensource.com>

This reverts commit a528b10cd6a552e92ed2b1b809c991a421ebdba6.

Fixing this in make-flight was incorrect -- make-flight should do as it was
told and use the appropriate TREE_LINUX(_ARCH) and REVISION_LINUX(_ARCH)
values it is given.

The real issue here was that these inputs were bogus for the linux-linus tree
when running on armhf and this will be fixed in a followup patch.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
---
 mfi-common | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/mfi-common b/mfi-common
index f7f981e..8f56092 100644
--- a/mfi-common
+++ b/mfi-common
@@ -44,11 +44,6 @@ create_build_jobs () {
 
     if [ "x$arch" = xdisable ]; then continue; fi
 
-    pvops_kernel="
-      tree_linux=$TREE_LINUX
-      revision_linux=${REVISION_LINUX:-${DEFAULT_REVISION_LINUX}}
-    "
-
     case "$arch" in
     armhf)
       case "$branch" in
@@ -64,13 +59,10 @@ create_build_jobs () {
       xen-4.1-testing) continue;;
       xen-4.2-testing) continue;;
       esac
-
-      if [ "$branch" = "linux-arm-xen" ]; then
-        pvops_kernel="
-          tree_linux=$TREE_LINUX_ARM
-          revision_linux=${REVISION_LINUX_ARM:-${DEFAULT_REVISION_LINUX_ARM}}
-        "
-      fi
+      pvops_kernel="
+        tree_linux=$TREE_LINUX_ARM
+        revision_linux=${REVISION_LINUX_ARM:-${DEFAULT_REVISION_LINUX_ARM}}
+      "
       pvops_kconfig_overrides="
         kconfig_override_y=CONFIG_EXT4_FS
       "
@@ -79,6 +71,10 @@ create_build_jobs () {
       case "$branch" in
       linux-arm-xen) continue;;
       esac
+      pvops_kernel="
+        tree_linux=$TREE_LINUX
+        revision_linux=${REVISION_LINUX:-${DEFAULT_REVISION_LINUX}}
+      "
       ;;
     esac
 
-- 
1.8.5.2

  reply	other threads:[~2014-02-11 12:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-09 16:04 [linux-linus test] 24817: regressions - FAIL xen.org
2014-02-10 10:37 ` [PATCH OSSTEST] mfi-common: Only override the pvops kernel repo for linux-arm-xen branch (Was: Re: [linux-linus test] 24817: regressions - FAIL) Ian Campbell
2014-02-10 11:48   ` Pasi Kärkkäinen
2014-02-10 12:01     ` Ian Campbell
2014-02-10 11:51   ` Ian Jackson
2014-02-10 12:00     ` Ian Campbell
2014-02-10 12:05       ` Ian Jackson
2014-02-10 12:10         ` Ian Campbell
2014-02-11 11:13   ` Ian Campbell
2014-02-11 12:39     ` [PATCH OSSTEST 0/2] fix tree and revision selection for linux branches under armhf Ian Campbell
2014-02-11 12:41       ` Ian Campbell [this message]
2014-02-11 12:42       ` [PATCH OSSTEST 2/2] cr-daily-branch: make sure we test the correct tree for Linux branches Ian Campbell
2014-02-11 15:06         ` Ian Jackson
2014-02-11 15:11           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392122520-5453-1-git-send-email-ian.campbell@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).