xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Campbell <ian.campbell@citrix.com>
Subject: [OSSTEST PATCH 09/12] ts-guests-nbd-mirror: add checkaccessible test
Date: Tue, 11 Feb 2014 15:25:51 +0000	[thread overview]
Message-ID: <1392132354-7594-10-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1392132354-7594-1-git-send-email-ian.jackson@eu.citrix.com>

If the NBD devices are not properly accessible on the client, bomb out
here rather than futilely starting a guest, and then timing out when
the guest fails to boot because it can't find its root fs.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 ts-guests-nbd-mirror |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/ts-guests-nbd-mirror b/ts-guests-nbd-mirror
index c0a021a..af200f4 100755
--- a/ts-guests-nbd-mirror
+++ b/ts-guests-nbd-mirror
@@ -116,7 +116,18 @@ sub shuffleconfigs () {
     }
 }
 
+sub checkaccessible () {
+    foreach my $v (@vols) {
+	my $finfo = target_cmd_output_root($cho, "file -Ls $v->{Path}");
+	chomp $finfo;
+	logm("file(1) on $v->{Path}: $finfo");
+	die "unexpected contents for $v->{Path}, nbd failed?"
+	    unless $finfo =~ m/filesystem|swap/i;
+    }
+}
+
 findvols();
 configserver();
 configclient();
 shuffleconfigs();
+checkaccessible();
-- 
1.7.10.4

  parent reply	other threads:[~2014-02-11 15:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-11 15:25 [OSSTEST PATCH 00/12] Wheezy Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 01/12] ts-xen-build-prep: avoid lvextend segfault (Debian #736173) with wheezy Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 02/12] ts-kernel-build: force CONFIG_BLK_DEV_NBD=y Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 03/12] ts-host-install: set `IPAPPEND 2' (if interface isn't forced) Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 04/12] ts-xen-install: nodhcp: restructure Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 05/12] ts-xen-install: default the interface to the one in /etc/network/interfaces Ian Jackson
2014-04-16 14:51   ` Ian Campbell
2014-04-16 15:02     ` Ian Jackson
2014-04-16 15:05       ` Ian Campbell
2014-04-17 15:13         ` [OSSTEST PATCH 1/3] ts-xen-install: nodhcp: Fix iface regexp Ian Jackson
2014-04-17 15:13           ` [OSSTEST PATCH 2/3] ts-xen-install: nohcp: Invert sense of interfaces loop Ian Jackson
2014-04-17 15:13           ` [OSSTEST PATCH 3/3] ts-xen-install: nodhcp: Make idempotent Ian Jackson
2014-04-22  8:41           ` [OSSTEST PATCH 1/3] ts-xen-install: nodhcp: Fix iface regexp Ian Campbell
2014-02-11 15:25 ` [OSSTEST PATCH 06/12] TestSupport: break out target_run_apt Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 07/12] TestSupport: Suppress prompting by apt Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 08/12] ts-guests-nbd-mirror: purge old packages first Ian Jackson
2014-02-11 15:25 ` Ian Jackson [this message]
2014-02-11 15:25 ` [OSSTEST PATCH 10/12] ts-guests-nbd-mirror: set "oldstyle=true" Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 11/12] Debian: Switch to wheezy Ian Jackson
2014-02-11 15:25 ` [OSSTEST PATCH 12/12] make-flight: abolish special-casing of suite for armhf Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392132354-7594-10-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).