From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: george.dunlap@eu.citrix.com,
Andrew Cooper <andrew.cooper3@citrix.com>,
keir@xen.org, JBeulich@suse.com, roger.pau@citrix.com
Subject: [PATCH v3 0/3] Move RTC interrupt injection back into the vpt code.
Date: Mon, 17 Feb 2014 11:29:34 +0000 [thread overview]
Message-ID: <1392636577-10305-1-git-send-email-andrew.cooper3@citrix.com> (raw)
Hi,
This series implements the most recent idea Tim was proposing about
reworking the RTC PF interrupt injection.
Patch 1 switches handling the !PIE case to calculate the right answer
for REG_C.PF on demand rather than running the timers.
Patch 2 switches back to the old model of having the vpt code control
the timer interrupt injection; this is the fix for the w2k3 hang.
Patch 3 is just a minor cleanup, and not particularly necessary.
v3 has undergone extensive testing in XenRT, confirming that the w2k3
has not reoccurred in 100 tests (normally expect to see 10-30
recurrences), and the clock drift tests are happy with the new code.
Roger:
Would you kindly test against FreeBSD again please?
George:
Regarding 4.4, I believe these patches are now of sufficient
quality to be accepted (subject to any other review).
The previous statements of risk still applies; These are changes to
a very complicated area of code, and the worst case scenario is that
a VM gets none/too few/too many timing interrupts, with possible
clock drift as a problem. The XenRT test results help alleviate
concern regarding the worst case.
~Andrew
next reply other threads:[~2014-02-17 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 11:29 Andrew Cooper [this message]
2014-02-17 11:29 ` [PATCH v3 1/3] x86/hvm/rtc: Don't run the vpt timer when !REG_B.PIE Andrew Cooper
2014-02-17 11:29 ` [PATCH v3 2/3] x86/hvm/rtc: Inject RTC periodic interupts from the vpt code Andrew Cooper
2014-02-17 11:29 ` [PATCH v3 3/3] x86/hvm/rtc: Always deassert the IRQ line when clearing REG_C.IRQF Andrew Cooper
2014-02-17 11:59 ` [PATCH v3 0/3] Move RTC interrupt injection back into the vpt code Jan Beulich
2014-02-17 13:19 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392636577-10305-1-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=george.dunlap@eu.citrix.com \
--cc=keir@xen.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).