From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH v3 3/3] x86/hvm/rtc: Always deassert the IRQ line when clearing REG_C.IRQF. Date: Mon, 17 Feb 2014 11:29:37 +0000 Message-ID: <1392636577-10305-4-git-send-email-andrew.cooper3@citrix.com> References: <1392636577-10305-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1392636577-10305-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: keir@xen.org, george.dunlap@eu.citrix.com, Andrew Cooper , Tim Deegan , JBeulich@suse.com, roger.pau@citrix.com List-Id: xen-devel@lists.xenproject.org From: Tim Deegan Even in no-ack mode, there's no reason to leave the line asserted after an explicit ack of the interrupt. Furthermore, rtc_update_irq() is an unconditional noop having just cleared RTC_REG_C. Signed-off-by: Tim Deegan Signed-off-by: Andrew Cooper --- xen/arch/x86/hvm/rtc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/rtc.c b/xen/arch/x86/hvm/rtc.c index d641d95..639b4c5 100644 --- a/xen/arch/x86/hvm/rtc.c +++ b/xen/arch/x86/hvm/rtc.c @@ -673,9 +673,8 @@ static uint32_t rtc_ioport_read(RTCState *s, uint32_t addr) check_for_pf_ticks(s); ret = s->hw.cmos_data[s->hw.cmos_index]; s->hw.cmos_data[RTC_REG_C] = 0x00; - if ( (ret & RTC_IRQF) && !rtc_mode_is(s, no_ack) ) + if ( ret & RTC_IRQF ) hvm_isa_irq_deassert(d, RTC_IRQ); - rtc_update_irq(s); check_update_timer(s); alarm_timer_update(s); s->pt_dead_ticks = 0; -- 1.7.10.4