From: Tim Deegan <tim@xen.org>
To: xen-devel@lists.xen.org
Subject: [PATCH v2 1/4] common/vsprintf: Explicitly treat negative lengths as 'unlimited'
Date: Thu, 27 Feb 2014 14:27:10 +0000 [thread overview]
Message-ID: <1393511233-28942-2-git-send-email-tim@xen.org> (raw)
In-Reply-To: <1393511233-28942-1-git-send-email-tim@xen.org>
The old code relied on implictly casting negative numbers to size_t
making a very large limit, which was correct but non-obvious.
Coverity CID 1128575
Signed-off-by: Tim Deegan <tim@xen.org>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/common/vsprintf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c
index 1a6198e..0a6fa05 100644
--- a/xen/common/vsprintf.c
+++ b/xen/common/vsprintf.c
@@ -239,7 +239,7 @@ static char *number(
static char *string(char *str, char *end, const char *s,
int field_width, int precision, int flags)
{
- int i, len = strnlen(s, precision);
+ int i, len = (precision < 0) ? strlen(s) : strnlen(s, precision);
if (!(flags & LEFT)) {
while (len < field_width--) {
--
1.8.5.2
next prev parent reply other threads:[~2014-02-27 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 14:27 [PATCH v2 0/4] more Coverity-inspired tidying Tim Deegan
2014-02-27 14:27 ` Tim Deegan [this message]
2014-02-28 15:07 ` [PATCH v2 1/4] common/vsprintf: Explicitly treat negative lengths as 'unlimited' Keir Fraser
2014-02-27 14:27 ` [PATCH v2 2/4] x86/shadow: Drop shadow_mode_trap_reads() Tim Deegan
2014-02-27 14:27 ` [PATCH v2 3/4] x86/mem_sharing: drop unused variable Tim Deegan
2014-02-27 14:27 ` [PATCH v2 4/4] bitmaps/bitops: Clarify tests for small constant size Tim Deegan
2014-02-27 16:30 ` Jan Beulich
2014-02-27 16:38 ` Tim Deegan
2014-02-28 14:40 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393511233-28942-2-git-send-email-tim@xen.org \
--to=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).