From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 4/5] [RFC] xen/console: Provide timestamps as an offset since boot
Date: Fri, 28 Feb 2014 18:57:03 +0000 [thread overview]
Message-ID: <1393613824-13230-5-git-send-email-andrew.cooper3@citrix.com> (raw)
In-Reply-To: <1393613824-13230-1-git-send-email-andrew.cooper3@citrix.com>
This adds a new "Linux style" console timestamp method, which is shorter and
more useful than the current date/time timestamps with single-second
granularity.
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
xen/drivers/char/console.c | 58 +++++++++++++++++++++++++++++++++++++-------
1 file changed, 49 insertions(+), 9 deletions(-)
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 532c426..652d02d 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -49,8 +49,17 @@ static bool_t __read_mostly opt_console_to_ring;
boolean_param("console_to_ring", opt_console_to_ring);
/* console_timestamps: include a timestamp prefix on every Xen console line. */
-static bool_t __read_mostly opt_console_timestamps;
-boolean_param("console_timestamps", opt_console_timestamps);
+enum con_timestamp_mode
+{
+ TSM_NONE, /* No timestamps */
+ TSM_DATE, /* [YYYY-MM-DD HH:MM:SS] */
+ TSM_SINCE_BOOT /* [SSSSSS.mmmmmm] */
+};
+
+static enum con_timestamp_mode __read_mostly opt_con_timestamp_mode = TSM_NONE;
+
+static void parse_console_timestamps(char *s);
+custom_param("console_timestamps", parse_console_timestamps);
/* conring_size: allows a large console ring than default (16kB). */
static uint32_t __initdata opt_conring_size;
@@ -546,23 +555,54 @@ static int printk_prefix_check(char *p, char **pp)
((loglvl < upper_thresh) && printk_ratelimit()));
}
+static void __init parse_console_timestamps(char *s)
+{
+ if ( *s == '\0' || /* Compat for old booleanparam() */
+ !strcmp(s, "date") )
+ opt_con_timestamp_mode = TSM_DATE;
+ else if ( !strcmp(s, "boot") )
+ opt_con_timestamp_mode = TSM_SINCE_BOOT;
+ else if ( !strcmp(s, "none") )
+ opt_con_timestamp_mode = TSM_NONE;
+ else
+ printk(XENLOG_ERR "Unrecognised timestamp mode '%s'\n", s);
+}
+
static void printk_start_of_line(const char *prefix)
{
struct tm tm;
char tstr[32];
+ uint64_t sec, nsec;
__putstr(prefix);
- if ( !opt_console_timestamps )
- return;
+ switch ( opt_con_timestamp_mode )
+ {
+ case TSM_DATE:
+ tm = wallclock_time();
+
+ if ( tm.tm_mday == 0 )
+ return;
+
+ if ( opt_con_timestamp_mode == TSM_DATE )
+ snprintf(tstr, sizeof(tstr), "[%04u-%02u-%02u %02u:%02u:%02u] ",
+ 1900 + tm.tm_year, tm.tm_mon + 1, tm.tm_mday,
+ tm.tm_hour, tm.tm_min, tm.tm_sec);
+ break;
+
+ case TSM_SINCE_BOOT:
+ sec = NOW();
+ nsec = do_div(sec, 1000000000);
- tm = wallclock_time();
- if ( tm.tm_mday == 0 )
+ snprintf(tstr, sizeof(tstr), "[%5"PRIu64".%06"PRIu64"] ",
+ sec, nsec / 1000);
+ break;
+
+ case TSM_NONE:
+ default:
return;
+ }
- snprintf(tstr, sizeof(tstr), "[%04u-%02u-%02u %02u:%02u:%02u] ",
- 1900 + tm.tm_year, tm.tm_mon + 1, tm.tm_mday,
- tm.tm_hour, tm.tm_min, tm.tm_sec);
__putstr(tstr);
}
--
1.7.10.4
next prev parent reply other threads:[~2014-02-28 18:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 18:56 [RFC PATCH v2 0/5] Improvements to console timestamps Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 1/5] x86/time: Avoid redundant this_cpu() Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 2/5] x86/time: Always count s_time from Xen boot Andrew Cooper
2014-03-03 10:59 ` David Vrabel
2014-03-06 16:01 ` [PATCH v3] " Tim Deegan
2014-03-06 16:15 ` Jan Beulich
2014-03-06 16:18 ` Andrew Cooper
2014-02-28 18:57 ` [PATCH v2 3/5] x86/time: Initialise time earlier during start_secondary() Andrew Cooper
2014-03-04 9:02 ` Jan Beulich
2014-03-04 10:40 ` Andrew Cooper
2014-02-28 18:57 ` Andrew Cooper [this message]
2014-03-03 10:53 ` [PATCH v2 4/5] [RFC] xen/console: Provide timestamps as an offset since boot David Vrabel
2014-02-28 18:57 ` [PATCH v2 5/5] [RFC] Traditional console timestamps including milliseconds Andrew Cooper
2014-03-01 4:06 ` Julien Grall
2014-03-03 10:35 ` Andrew Cooper
2014-03-04 9:14 ` Jan Beulich
2014-03-04 10:30 ` Andrew Cooper
2014-03-04 20:51 ` Don Slutz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393613824-13230-5-git-send-email-andrew.cooper3@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).