xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: xen-devel@lists.xenproject.org, jbeulich@suse.com
Subject: [PATCH v1 3/4] serial: Use #defines for PCI vendor and models
Date: Wed,  5 Mar 2014 12:25:33 -0500	[thread overview]
Message-ID: <1394040334-16278-4-git-send-email-konrad.wilk@oracle.com> (raw)
In-Reply-To: <1394040334-16278-1-git-send-email-konrad.wilk@oracle.com>

Instead of having hard-coded values.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen/drivers/char/ns16550.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 06580c8..6fbf358 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -131,17 +131,21 @@ static struct ns16550_config_quirk __initdata uart_quirk[] = {
         .max_bars = 1, /* It can do more, but we would need more custom code.*/
     }
 };
+
+#define PCI_VENDOR_ID_BROADCOM           0x14e4
+#define PCI_DEVICE_ID_BROADCOM_TRUMANAGE 0x160a
+#define PCI_VENDOR_ID_OXSEMI             0x1415
 static struct ns16550_config_mmio __initdata uart_config[] =
 {
     /* Broadcom TruManage device */
     {
-        .vendor_id = 0x14e4,
-        .dev_id = 0x160a,
+        .vendor_id = PCI_VENDOR_ID_BROADCOM,
+        .dev_id = PCI_DEVICE_ID_BROADCOM_TRUMANAGE,
         .quirk = quirk_trumanage,
     },
     /* OXPCIe952 1 Native UART  */
     {
-        .vendor_id = 0x1415,
+        .vendor_id = PCI_VENDOR_ID_OXSEMI,
         .dev_id = 0xc138,
         .quirk = quirk_oxford,
     }
-- 
1.7.7.6

  parent reply	other threads:[~2014-03-05 17:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 17:25 [PATCH v1] Enable serial output for Oxford Semiconductor PCIe cards Konrad Rzeszutek Wilk
2014-03-05 17:25 ` [PATCH v1 1/4] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138) Konrad Rzeszutek Wilk
2014-03-06 10:15   ` Jan Beulich
2014-03-06 18:47     ` Konrad Rzeszutek Wilk
2014-03-05 17:25 ` [PATCH v1 2/4] serial: Seperate the PCI device ids and quirks Konrad Rzeszutek Wilk
2014-03-06 10:17   ` Jan Beulich
2014-03-06 18:48     ` Konrad Rzeszutek Wilk
2014-03-05 17:25 ` Konrad Rzeszutek Wilk [this message]
2014-03-05 17:34   ` [PATCH v1 3/4] serial: Use #defines for PCI vendor and models Andrew Cooper
2014-03-06 10:18   ` Jan Beulich
2014-03-05 17:25 ` [PATCH v1 4/4] serial: Expand the PCI serial quirks for OXPCIe200 and OXPCIe952 1 Native UART Konrad Rzeszutek Wilk
2014-03-06 10:20   ` Jan Beulich
2014-03-07 15:55     ` Konrad Rzeszutek Wilk
2014-03-07 16:30       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394040334-16278-4-git-send-email-konrad.wilk@oracle.com \
    --to=konrad@kernel.org \
    --cc=jbeulich@suse.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).