From: Dario Faggioli <dario.faggioli@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>
Cc: Marcus Granado <Marcus.Granado@eu.citrix.com>,
Keir Fraser <keir@xen.org>,
George Dunlap <george.dunlap@eu.citrix.com>,
Tim Deegan <tim@xen.org>,
xen-devel@lists.xen.org, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] credit: Change default timeslice to 5ms
Date: Wed, 5 Mar 2014 19:04:26 +0100 [thread overview]
Message-ID: <1394042666.16409.46.camel@Solace> (raw)
In-Reply-To: <53175C5C.4060505@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1159 bytes --]
On mer, 2014-03-05 at 17:18 +0000, David Vrabel wrote:
> On 05/03/14 16:29, George Dunlap wrote:
> > --- a/xen/common/sched_credit.c
> > +++ b/xen/common/sched_credit.c
> > @@ -29,9 +29,9 @@
> > * Basic constants
> > */
> > #define CSCHED_DEFAULT_WEIGHT 256
> > -#define CSCHED_TICKS_PER_TSLICE 3
> > -/* Default timeslice: 30ms */
> > -#define CSCHED_DEFAULT_TSLICE_MS 30
> > +#define CSCHED_TICKS_PER_TSLICE 1
>
> The TICKS_PER_TSLICE change doubles the tick rate. Is this intentional?
> It's not mentioned in the commit message.
>
Well, I guess higher tick rate is exactly what you expect from reducing
the timeslice... otherwise, you could not be able to enforce the
timeslice boundaries precisely, could you?
It's unavoidable, I think: if you stick with a tick every 30ms/3=10ms,
how can you enforce a timeslice of 5ms?
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-03-05 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 16:29 [PATCH] credit: Change default timeslice to 5ms George Dunlap
2014-03-05 16:33 ` Dario Faggioli
2014-03-05 17:18 ` David Vrabel
2014-03-05 18:04 ` Dario Faggioli [this message]
2014-03-06 12:04 ` George Dunlap
2014-03-06 12:27 ` Dario Faggioli
2014-03-06 10:39 ` Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394042666.16409.46.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Marcus.Granado@eu.citrix.com \
--cc=david.vrabel@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).