From: Arianna Avanzini <avanzini.arianna@gmail.com>
To: xen-devel@lists.xen.org
Cc: Ian.Campbell@eu.citrix.com, paolo.valente@unimore.it,
stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com,
Ian.Jackson@eu.citrix.com, julien.grall@citrix.com,
etrudeau@broadcom.com, avanzini.arianna@gmail.com,
viktor.kleinik@globallogic.com
Subject: [RFC PATCH v2 3/3] tools, libxl: handle the iomem parameter with the memory_mapping hcall
Date: Mon, 10 Mar 2014 09:25:53 +0100 [thread overview]
Message-ID: <1394439953-5723-4-git-send-email-avanzini.arianna@gmail.com> (raw)
In-Reply-To: <1394439953-5723-1-git-send-email-avanzini.arianna@gmail.com>
Currently, the configuration-parsing code concerning the handling of the
iomem parameter only invokes the XEN_DOMCTL_iomem_permission hypercall.
This commit lets the XEN_DOMCTL_memory_mapping hypercall be invoked
after XEN_DOMCTL_iomem_permission when the iomem parameter is parsed
from a domU configuration file, so that the address range can be mapped
to the address space of the domU.
NOTE: the added code is still common to both x86 and ARM; it also
implements a simple 1:1 mapping that could clash with the domU's
existing memory layout if the range is already in use in the
guest's address space.
Signed-off-by: Arianna Avanzini <avanzini.arianna@gmail.com>
Cc: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Paolo Valente <paolo.valente@unimore.it>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Eric Trudeau <etrudeau@broadcom.com>
Cc: Viktor Kleinik <viktor.kleinik@globallogic.com>
---
tools/libxl/libxl_create.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index a604cd8..6c206c3 100644
--- a/tools/libxl/libxl_create.c
+++ b/tools/libxl/libxl_create.c
@@ -1099,6 +1099,23 @@ static void domcreate_launch_dm(libxl__egc *egc, libxl__multidev *multidev,
"failed give dom%d access to iomem range %"PRIx64"-%"PRIx64,
domid, io->start, io->start + io->number - 1);
ret = ERROR_FAIL;
+ } else {
+ /*
+ * NOTE: the following code is still common to both x86
+ * and ARM; it also implements a simple 1:1 mapping
+ * that could clash with the domU's existing memory
+ * layout if the range is already in use in the
+ * guest's address space.
+ */
+ ret = xc_domain_memory_mapping(CTX->xch, domid,
+ io->start, io->start,
+ io->number, 1);
+ if (ret < 0) {
+ LOGE(ERROR,
+ "failed to map to dom%d iomem range %"PRIx64"-%"PRIx64,
+ domid, io->start, io->start + io->number - 1);
+ ret = ERROR_FAIL;
+ }
}
}
--
1.9.0
next prev parent reply other threads:[~2014-03-10 8:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 8:25 [RFC PATCH v2 0/3] Implement the XEN_DOMCTL_memory_mapping hypercall for ARM Arianna Avanzini
2014-03-10 8:25 ` [RFC PATCH v2 1/3] arch, arm: allow dom0 access to I/O memory of mapped devices Arianna Avanzini
2014-03-10 11:30 ` Julien Grall
2014-03-11 0:49 ` Arianna Avanzini
2014-03-13 15:27 ` Ian Campbell
2014-03-13 15:40 ` Julien Grall
2014-03-10 8:25 ` [RFC PATCH v2 2/3] arch, arm: add the XEN_DOMCTL_memory_mapping hypercall Arianna Avanzini
2014-03-10 12:03 ` Julien Grall
2014-03-11 1:20 ` Arianna Avanzini
2014-03-13 15:29 ` Ian Campbell
2014-03-13 15:36 ` Jan Beulich
2014-03-13 15:51 ` Dario Faggioli
2014-03-13 15:57 ` Ian Campbell
2014-03-13 16:08 ` Jan Beulich
2014-03-10 8:25 ` Arianna Avanzini [this message]
2014-03-13 15:27 ` [RFC PATCH v2 3/3] tools, libxl: handle the iomem parameter with the memory_mapping hcall Ian Campbell
2014-03-13 15:34 ` Julien Grall
2014-03-13 15:49 ` Ian Campbell
2014-03-13 16:36 ` Dario Faggioli
2014-03-13 16:47 ` Julien Grall
2014-03-13 17:32 ` Ian Campbell
2014-03-13 18:37 ` Dario Faggioli
2014-03-13 20:29 ` Julien Grall
2014-03-14 9:55 ` Dario Faggioli
2014-03-14 9:46 ` Ian Campbell
2014-03-14 12:00 ` Julien Grall
2014-03-14 12:15 ` Dario Faggioli
2014-03-14 12:39 ` Arianna Avanzini
2014-03-14 12:49 ` Ian Campbell
2014-03-14 15:10 ` Stefano Stabellini
2014-03-14 15:45 ` Dario Faggioli
2014-03-14 16:19 ` Ian Campbell
2014-03-14 16:25 ` Dario Faggioli
2014-03-14 18:39 ` Eric Trudeau
2014-03-17 9:37 ` Ian Campbell
2014-03-13 15:43 ` Jan Beulich
2014-03-13 15:51 ` Ian Campbell
2014-03-13 16:53 ` Dario Faggioli
2014-03-13 17:04 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394439953-5723-4-git-send-email-avanzini.arianna@gmail.com \
--to=avanzini.arianna@gmail.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=etrudeau@broadcom.com \
--cc=julien.grall@citrix.com \
--cc=paolo.valente@unimore.it \
--cc=stefano.stabellini@eu.citrix.com \
--cc=viktor.kleinik@globallogic.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).