Re: [PATCH 3/4] libxl: report how much memory a domain has on each NUMA node

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2432 bytes --]

On lun, 2014-03-10 at 16:40 +0000, Ian Jackson wrote:
> Dario Faggioli writes ("[PATCH 3/4] libxl: report how much memory a domain has on each NUMA node"):
> > by calling xc_domain_numainfo(). A new data type, libxl_domain_numainfo
> > is being introduced. For now it only holds how much memory a domain has
> > allocated on each NUMA node, but it can be useful for, in future,
> > reporting more per-domain NUMA related information.
> 
> Is there some reason this shouldn't be in the normal domain info
> struct ?
> 
Nothing other than personal taste. For consistency with getting/setting
node affinity, I introduced a call to retrieve this, and specifically.
Having done that, I decided to use an independent struct also.

There is no harm in moving it somewhere else, if you like that better.

Just to be sure, you mean putting it in here:
libxl_dominfo = Struct("dominfo",[
    ("uuid",        libxl_uuid),
    ("domid",       libxl_domid),
    ("ssidref",     uint32),
    ("running",     bool),
    ("blocked",     bool),
    ("paused",      bool),
    ("shutdown",    bool),
    ("dying",       bool),
    
    # Valid iff (shutdown||dying).
    # 
    # Otherwise set to a value guaranteed not to clash with any valid
    # LIBXL_SHUTDOWN_REASON_* constant.
    ("shutdown_reason", libxl_shutdown_reason),
    ("outstanding_memkb",  MemKB),
    ("current_memkb",   MemKB),
    ("shared_memkb", MemKB),
    ("paged_memkb", MemKB),
    ("max_memkb",   MemKB),
    ("cpu_time",    uint64),
    ("vcpu_max_id", uint32),                 
    ("vcpu_online", uint32),              
    ("cpupool",     uint32),
    ("domain_type", libxl_domain_type),
    ], dir=DIR_OUT) 

and retrieving by calling libxl_list_domain, right?

In which case, I don't think it will be that easy to have a function
that retrieves specifically  this information (and whatever else we
could be wanting to stash in a libxl_domain_numainfo, type... Do you see
any issue in dropping it? (The problem, of course, won't be the
function, but what to return from it, if I decide not to introduce an
ad-hoc type).

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel