From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lai Jiangshan Subject: [PATCH 4/5] xc_save: avoid to alloc local constant string Date: Tue, 11 Mar 2014 22:15:24 +0800 Message-ID: <1394547325-18537-4-git-send-email-laijs@cn.fujitsu.com> References: <1394547325-18537-1-git-send-email-laijs@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394547325-18537-1-git-send-email-laijs@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: Keir Fraser , Ian Jackson , Ian Campbell , Lai Jiangshan List-Id: xen-devel@lists.xenproject.org cmd_str will only cleanup by other place, it don't need to be allocated. Signed-off-by: Lai Jiangshan --- tools/xcutils/xc_save.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/tools/xcutils/xc_save.c b/tools/xcutils/xc_save.c index e34bd2c..1304433 100644 --- a/tools/xcutils/xc_save.c +++ b/tools/xcutils/xc_save.c @@ -128,8 +128,7 @@ static int switch_qemu_logdirty(int domid, unsigned int enable, void *data) if (!xs_watch(xs, path, "qemu-logdirty-ret")) errx(1, "can't set watch in store (%s)\n", path); - if (!(cmd_str = strdup( enable == 0 ? "disable" : "enable"))) - errx(1, "can't get logdirty cmd path in store"); + cmd_str = enable == 0 ? "disable" : "enable"; /* Tell qemu that we want it to start logging dirty page to Xen */ strcpy(p, "cmd"); @@ -157,7 +156,6 @@ static int switch_qemu_logdirty(int domid, unsigned int enable, void *data) goto read_again; free(path); - free(cmd_str); free(ret_str); return 0; -- 1.7.1