From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH RFC 1/2] tools/libxc: Improved xc_{topology, numa}info functions. Date: Wed, 12 Mar 2014 12:00:06 +0100 Message-ID: <1394622006.17832.88.camel@Solace> References: <1393499497-9162-1-git-send-email-andrew.cooper3@citrix.com> <1393499497-9162-2-git-send-email-andrew.cooper3@citrix.com> <1394613247.31942.45.camel@Abyss> <532039C5.1070100@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0094257784417262313==" Return-path: In-Reply-To: <532039C5.1070100@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Andrew Cooper Cc: Ian Jackson , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org --===============0094257784417262313== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-XAvS1p2xY9Qh6S/8IE9Y" --=-XAvS1p2xY9Qh6S/8IE9Y Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On mer, 2014-03-12 at 10:41 +0000, Andrew Cooper wrote: > On 12/03/14 08:34, Dario Faggioli wrote: > I certainly can modify the original ones directly. When developing, > it in the 4.4 freeze, and I wanted my changes to easily co-exist with > libxc. (If you notice, these patches are in XenServer trunk for easy > deployment against our entire set of weird & wacky hardware). >=20 Sure, I know. That's why I sent this 'kind-of-ping' :-) > If there general agreement that making the old > xc_{topology,numa}info() functions have the prototype and behaviour of > my _bounced variants, then I will happy do that, and send some fixup > to make libxl work against it. >=20 Of course. Let's hear maintainers. FWIW, I vote for it. As you already say in the cover letter of the series, the current implementation in both libxc and libxl is a pain to use and maintain, and set a very ba example for people wanting to do similar things. In fact, it was me that, as one of my first contributions to Xen, (re)implemented libxl_get_numainfo(), out of inspiration from libxl_get_cpu_topology()! :-/ So, to summarize my view, let's switch the existing to yours ASAP. Ian-s? :-) Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-XAvS1p2xY9Qh6S/8IE9Y Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlMgPjYACgkQk4XaBE3IOsRTvACZAdcp3nZqWCXnpt/Qep1z8zaJ OLMAn3wE9+ysNtERM3z/m0agZYjGTVan =SOpw -----END PGP SIGNATURE----- --=-XAvS1p2xY9Qh6S/8IE9Y-- --===============0094257784417262313== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============0094257784417262313==--