xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH 0/5] Improvements with __attribute__((packed))
Date: Wed, 12 Mar 2014 19:08:34 +0000	[thread overview]
Message-ID: <1394651319-8893-1-git-send-email-andrew.cooper3@citrix.com> (raw)

Due to a lack of suitable define in scope, mce-apei.c ends up accidentally
creating a global unreferenced struct of type 'cper_mce_record', named
'__packed'.

This series is a cleanup of all use of __attribute__((packed)) in Xen.  A
formal define is created in compiler.h, all opencoded uses of the attribute
are updated to use the new define (or dropped if unnecessary in the first
place), and the position of __packed is standardised at the beginning of the
struct rather than the end, so a lack of __packed in scope will result in a
compile error.

Patch 1 drops some redundant uses of __attribute__((packed)), and is verified
by diffing xen-syms.

Patches 2 through 4 make the main changes, and are split up by core component
for the benefit of the maintainers/reviewers.

Patch 5 is only for people wishing to verify my assertions.  The entire
series including patch 5 compiles to identical binaries, proving that the
reverse contents of patch 5 are the only semantic differences across the
series.

This is compile tested on each architecture and functionally tested on x86.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

             reply	other threads:[~2014-03-12 19:08 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 19:08 Andrew Cooper [this message]
2014-03-12 19:08 ` [PATCH 1/5] xen: Remove redundant __attribute__((packed)) statements Andrew Cooper
2014-03-13  8:06   ` Jan Beulich
2014-03-13 10:38     ` Andrew Cooper
2014-03-13 10:49   ` George Dunlap
2014-03-12 19:08 ` [PATCH 2/5] xen/common: Cleanup use of __attribute__((packed)) Andrew Cooper
2014-03-13  8:15   ` Jan Beulich
2014-03-13 10:22     ` Andrew Cooper
2014-03-13 10:40       ` Jan Beulich
2014-03-13 10:42         ` Andrew Cooper
2014-03-12 19:08 ` [PATCH 3/5] xen/x86: " Andrew Cooper
2014-03-13  8:32   ` Jan Beulich
2014-03-13 11:00     ` Andrew Cooper
2014-03-13 11:13       ` Jan Beulich
2014-03-13 11:36         ` Keir Fraser
2014-03-12 19:08 ` [PATCH 4/5] xen/arm: " Andrew Cooper
2014-03-13  8:34   ` Jan Beulich
2014-03-13  9:55     ` Ian Campbell
2014-03-13  9:59       ` Tim Deegan
2014-03-13 10:01         ` Ian Campbell
2014-03-13 10:02       ` Jan Beulich
2014-03-12 19:08 ` [PATCH 5/5] DO NOT APPLY: for verification purposes only Andrew Cooper
2014-03-13  6:31 ` [PATCH 0/5] Improvements with __attribute__((packed)) Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394651319-8893-1-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).