From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH v2] tools/mfndump: Avoid unintentional NULL
	dereference
Date: Thu, 13 Mar 2014 13:53:52 +0100
Message-ID: <1394715232.4159.4.camel@Solace>
References: <1394708774.25873.45.camel@kazak.uk.xensource.com>
	<1394708947-29113-1-git-send-email-andrew.cooper3@citrix.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2595593820173069197=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1394708947-29113-1-git-send-email-andrew.cooper3@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

--===============2595593820173069197==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-PbnZKb+9k2yYJbyNxMCe"

--=-PbnZKb+9k2yYJbyNxMCe
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On gio, 2014-03-13 at 11:09 +0000, Andrew Cooper wrote:
> If we failed to open an xc interface, using xch to log an error will end =
in
> tears.  Print to stderr instead, as we are bailing immediately later.
>=20
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> Coverity-id: 1191885
> Acked-by: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Dario Faggioli <dario.faggioli@citrix.com>
>=20
If this is not yet in, feel free to add:

Acked-by: Dario Faggioli <dario.faggioli@citrix.com>

Because, I confirm, I did unintentionally and not deliberately! :-P

> v2: Reword subject
>=20
> This is why macros depending on variables in scope, particularly ones nam=
ed
> as simily as "ERROR", are evil.
>
I Could not agree more!

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


--=-PbnZKb+9k2yYJbyNxMCe
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEABECAAYFAlMhqmEACgkQk4XaBE3IOsRXDgCgo4wJX4Py2dWqLnqm0dlA275R
qL8AnRvFb0seVBHZZHv+jrfGPl20qZBq
=ZQRC
-----END PGP SIGNATURE-----

--=-PbnZKb+9k2yYJbyNxMCe--


--===============2595593820173069197==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============2595593820173069197==--