xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Xen-devel <xen-devel@lists.xen.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: [PATCH v2 0/5] Improvements to the use of __attribute__((packed))
Date: Thu, 13 Mar 2014 15:04:15 +0000	[thread overview]
Message-ID: <1394723060-24158-1-git-send-email-andrew.cooper3@citrix.com> (raw)

Due to a lack of suitable define in scope, mce-apei.c ends up accidentally
creating a global unreferenced struct of type 'cper_mce_record', named
'__packed'.

This series is a cleanup of all use of __attribute__((packed)) in Xen.  A
formal define is created in compiler.h, all opencoded uses of the attribute
are updated to use the new define and the position of __packed is standardised
at the beginning of the struct rather than the end, so a lack of __packed in
scope will result in a compile error.

Patch 1 makes all the changes which have a material effect on Xen.

Patches 2 through 5 provide no functional change, but provide consistency with
the use of __attribute__((packed)) across the code.  They can be verified as
noops by diffing the resulting xen-syms.

This is compile tested on each architecture and functionally tested on x86.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

             reply	other threads:[~2014-03-13 15:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 15:04 Andrew Cooper [this message]
2014-03-13 15:04 ` [PATCH v2 1/5] xen/misc: Functional cleanup for __attribute__((packed)) changes Andrew Cooper
2014-03-13 16:22   ` Jan Beulich
2014-03-13 16:30     ` Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 2/5] xen/common: Shuffle use of __attribute__((packed)) Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 3/5] xen/x86: " Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 4/5] xen/arm: " Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 5/5] xen/x86_emulate: " Andrew Cooper
2014-03-13 16:08   ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394723060-24158-1-git-send-email-andrew.cooper3@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).