From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: [PATCH v2 1/5] xen/misc: Functional cleanup for __attribute__((packed)) changes Date: Thu, 13 Mar 2014 15:04:16 +0000 Message-ID: <1394723060-24158-2-git-send-email-andrew.cooper3@citrix.com> References: <1394723060-24158-1-git-send-email-andrew.cooper3@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394723060-24158-1-git-send-email-andrew.cooper3@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Xen-devel Cc: George Dunlap , Andrew Cooper , Eddie Dong , Jun Nakajima , Jan Beulich List-Id: xen-devel@lists.xenproject.org This is to separate the functional changes from the noop consistency changes. * Pack struct cper_mce_record rather than creating a structure named __packed * Remove unreferenced struct xgt_desc * Use two u16's rather than two u32 16-bit bitfields Signed-off-by: Andrew Cooper Acked-by: Keir Fraser CC: Jan Beulich CC: George Dunlap CC: Jun Nakajima CC: Eddie Dong --- xen/arch/x86/cpu/mcheck/mce-apei.c | 2 +- xen/arch/x86/hvm/vmx/vmcs.c | 5 ----- xen/common/trace.c | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce-apei.c b/xen/arch/x86/cpu/mcheck/mce-apei.c index 3370341..f9168b0 100644 --- a/xen/arch/x86/cpu/mcheck/mce-apei.c +++ b/xen/arch/x86/cpu/mcheck/mce-apei.c @@ -53,7 +53,7 @@ struct cper_mce_record { struct cper_record_header hdr; struct cper_section_descriptor sec_hdr; struct mce mce; -} __packed; +} __attribute__((packed)); /* Reset to default packing */ #pragma pack() diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 9ffb4af..4b886e5 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -670,11 +670,6 @@ void vmx_vmcs_exit(struct vcpu *v) } } -struct xgt_desc { - unsigned short size; - unsigned long address __attribute__((packed)); -}; - static void vmx_set_host_env(struct vcpu *v) { unsigned int cpu = smp_processor_id(); diff --git a/xen/common/trace.c b/xen/common/trace.c index 41ddc33..73ba57c 100644 --- a/xen/common/trace.c +++ b/xen/common/trace.c @@ -643,7 +643,7 @@ static inline void insert_lost_records(struct t_buf *buf) { struct { u32 lost_records; - u32 did:16, vid:16; + u16 did, vid; u64 first_tsc; } __attribute__((packed)) ed; -- 1.7.10.4