From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [RFC PATCH v2 2/3] arch, arm: add the XEN_DOMCTL_memory_mapping hypercall Date: Thu, 13 Mar 2014 16:51:46 +0100 Message-ID: <1394725906.4159.28.camel@Solace> References: <1394439953-5723-1-git-send-email-avanzini.arianna@gmail.com> <1394439953-5723-3-git-send-email-avanzini.arianna@gmail.com> <1394724552.25873.106.camel@kazak.uk.xensource.com> <5321DE870200007800123CE6@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8584036864064106226==" Return-path: In-Reply-To: <5321DE870200007800123CE6@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: paolo.valente@unimore.it, Keir Fraser , Ian Campbell , stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, julien.grall@citrix.com, etrudeau@broadcom.com, Arianna Avanzini , viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org --===============8584036864064106226== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-FzU/An2b2/Xodgz7FB5R" --=-FzU/An2b2/Xodgz7FB5R Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On gio, 2014-03-13 at 15:36 +0000, Jan Beulich wrote: > >>> On 13.03.14 at 16:29, Ian Campbell wrote: > > "foo + foo_mfns" appears quite a lot here. I think you could calculate > > those once into foo_start and foo_end and use throughout which would > > make the remainder much easier to follow. > >=20 > > Oh, I see this came from the x86 function of which this is an almost > > complete copy -- can it not be made common? > >=20 > > The difference seems to be map_mmio_regions vs. a loop over > > set_mmio_p2m_entry which seems easy enough to abstract out. >=20 > Indeed. >=20 But, if I can ask, from where does this difference come from? If Arianna is to make this common code, should she retain such difference or kill it? I mean, do we want to keep having x86 mapping in loop and ARM mapping all at once, or can we just merge that part two? If the former, why? ISTR, Arianna asked this already, but the answer was something like "mapping all at once" is correct (someone correct me if I'm wrong). Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-FzU/An2b2/Xodgz7FB5R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlMh1BIACgkQk4XaBE3IOsTb0ACfea2SieWA9rY9/FCvVU4g1TAp is4An1oqBhFH1Epy94rKWWvFOGqtlFEt =EW1W -----END PGP SIGNATURE----- --=-FzU/An2b2/Xodgz7FB5R-- --===============8584036864064106226== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============8584036864064106226==--