From: Dario Faggioli <dario.faggioli@citrix.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel@lists.xenproject.org,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
coverity@xenproject.org
Subject: Re: xen-mfndump xch bug (was Re: New Defects reported by Coverity Scan for XenProject)
Date: Thu, 13 Mar 2014 18:36:38 +0100 [thread overview]
Message-ID: <1394732198.4159.69.camel@Solace> (raw)
In-Reply-To: <1394732103.16364.38.camel@kazak.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 975 bytes --]
On gio, 2014-03-13 at 17:35 +0000, Ian Campbell wrote:
> On Thu, 2014-03-13 at 18:19 +0100, Dario Faggioli wrote:
> > > Furthermore, I was rather startled to discover that xen-mfndump.c
> > > #includes <xc_private.h>.
> > >
> > Makes sense... Sorry for that. I think I remember, when working on it,
> > starting from copying tools/misc/xen-hptool.c
>
> (begs the question why this guy needs it too, oh well)
>
Indeed. :-)
> > , and then modifying it for
> > my purposes. I probably just left the #include-s untouched without much
> > thinking.
> >
> > Do you want me to try to remove it and send a patch to that effect?
>
> Yes Please.
>
I'll do, and try to kill both uses.
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-03-13 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <532047fec9998_3c9c450684431a@209.249.196.67.mail>
2014-03-13 17:05 ` xen-mfndump xch bug (was Re: New Defects reported by Coverity Scan for XenProject) Ian Jackson
2014-03-13 17:19 ` Dario Faggioli
2014-03-13 17:23 ` Andrew Cooper
2014-03-13 17:35 ` Ian Campbell
2014-03-13 17:36 ` Dario Faggioli [this message]
2014-03-14 11:37 ` Ian Jackson
2014-03-14 11:45 ` Dario Faggioli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394732198.4159.69.camel@Solace \
--to=dario.faggioli@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=coverity@xenproject.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).