From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 4/5] tools, libxl: parse optional start gfn from the iomem config option Date: Mon, 17 Mar 2014 11:01:42 +0100 Message-ID: <1395050502.4159.254.camel@Solace> References: <1394914286-29713-1-git-send-email-avanzini.arianna@gmail.com> <1394914286-29713-5-git-send-email-avanzini.arianna@gmail.com> <5324D5AA.6000100@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3595001863588803393==" Return-path: In-Reply-To: <5324D5AA.6000100@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: julien.grall@citrix.com, paolo.valente@unimore.it, keir@xen.org, stefano.stabellini@eu.citrix.com, tim@xen.org, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, Ian.Campbell@eu.citrix.com, etrudeau@broadcom.com, JBeulich@suse.com, Arianna Avanzini , viktor.kleinik@globallogic.com List-Id: xen-devel@lists.xenproject.org --===============3595001863588803393== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-lDqGcqjG0p0LYksNdnvU" --=-lDqGcqjG0p0LYksNdnvU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On sab, 2014-03-15 at 22:35 +0000, Julien Grall wrote: > On 15/03/14 20:11, Arianna Avanzini wrote: > > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5 > > index a6663b9..d9684f2 100644 > > --- a/docs/man/xl.cfg.pod.5 > > +++ b/docs/man/xl.cfg.pod.5 > > @@ -602,12 +602,13 @@ is given in hexadecimal and may either a span e.g= . C<2f8-2ff> > > It is recommended to use this option only for trusted VMs under > > administrator control. > > > > -=3Ditem B > > +=3Ditem B > > > > Allow guest to access specific hardware I/O memory pages. B > > is a physical page number. B is the number > > -of pages beginning with B to allow access. Both values > > -must be given in hexadecimal. > > +of pages beginning with B to allow access. B specifie= s > > +the guest frame number where the mapping will start in the domU's > > +address space. All of these values must be given in hexadecimal. > > > > It is recommended to use this option only for trusted VMs under > > administrator control. > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl > > index 612645c..f0bdb09 100644 > > --- a/tools/libxl/libxl_types.idl > > +++ b/tools/libxl/libxl_types.idl > > @@ -172,6 +172,7 @@ libxl_ioport_range =3D Struct("ioport_range", [ > > libxl_iomem_range =3D Struct("iomem_range", [ > > ("start", uint64), > > ("number", uint64), > > + ("gfn", uint64), >=20 > I'm not a libxl expert, but you are modifying an existing structure. Ian= =20 > & Ian, do we need to bump the interface version? >=20 I think what we need is the proper LIBXL_HAVE_FOO stuff. * In the event that a change is required which cannot be made * backwards compatible in this manner a #define of the form * LIBXL_HAVE_ will always be added in order to make it * possible to write applciations which build against any version of * libxl.=20 Arianna, try this: $ grep LIBXL_HAVE_ tools/libxl/libxl.h And look at one of the examples, e.g.: /* * LIBXL_HAVE_DOMAIN_NODEAFFINITY indicates that a 'nodemap' field * (of libxl_bitmap type) is present in libxl_domain_build_info, * containing the node-affinity for the domain. */ #define LIBXL_HAVE_DOMAIN_NODEAFFINITY 1 The commit this was introduced by is a5d30c23, in case that helps. Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-lDqGcqjG0p0LYksNdnvU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iEYEABECAAYFAlMmyAYACgkQk4XaBE3IOsRPtACfQpcbXJImVjuGNbz+NmHXif8P Q/oAmgOOUfSNQHRLQPI9XXdZeXZjmbcd =m+Do -----END PGP SIGNATURE----- --=-lDqGcqjG0p0LYksNdnvU-- --===============3595001863588803393== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3595001863588803393==--