xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: xen-devel@lists.xensource.com
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Subject: [PATCH 1/5] xl: remove needless error checking from calls to xl_fork
Date: Wed, 19 Mar 2014 14:28:50 +0000	[thread overview]
Message-ID: <1395239334-19579-2-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1395239334-19579-1-git-send-email-ian.jackson@eu.citrix.com>

xl_fork cannot fail - it exits instead.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Ian Campbell <Ian.Campbell@citrix.com>
---
 tools/libxl/xl_cmdimpl.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
index 8990020..e19b1cf 100644
--- a/tools/libxl/xl_cmdimpl.c
+++ b/tools/libxl/xl_cmdimpl.c
@@ -230,10 +230,7 @@ static void autoconnect_vncviewer(uint32_t domid, int autopass)
     vncviewer_child_report();
 
     pid_t pid = xl_fork(child_vncviewer);
-    if (pid < 0) {
-        perror("unable to fork vncviewer");
-        return;
-    } else if (pid > 0)
+    if (pid)
         return;
 
     postfork();
@@ -2009,10 +2006,7 @@ static void autoconnect_console(libxl_ctx *ctx_ignored,
     console_child_report();
 
     pid_t pid = xl_fork(child_console);
-    if (pid < 0) {
-        perror("unable to fork xenconsole");
-        return;
-    } else if (pid > 0)
+    if (pid)
         return;
 
     postfork();
-- 
1.7.10.4

  reply	other threads:[~2014-03-19 14:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 14:28 [PATCH 0/5] xl: console error handling improvements Ian Jackson
2014-03-19 14:28 ` Ian Jackson [this message]
2014-03-21 13:47   ` [PATCH 1/5] xl: remove needless error checking from calls to xl_fork Ian Campbell
2014-03-19 14:28 ` [PATCH 2/5] xl: Introduce children[].description and xl_report_child_exitstatus Ian Jackson
2014-03-21 13:47   ` Ian Campbell
2014-03-19 14:28 ` [PATCH 3/5] xl: Abolish vncviewer_child_report Ian Jackson
2014-03-21 13:48   ` Ian Campbell
2014-03-21 14:33     ` [PATCH 3/5] xl: Abolish vncviewer_child_report [and 1 more messages] Ian Jackson
2014-03-19 14:28 ` [PATCH 4/5] xl: Remove clone-and-hack in do_daemonize Ian Jackson
2014-03-21 13:49   ` Ian Campbell
2014-03-19 14:28 ` [PATCH 5/5] xl: console connection: Print errno value from exec Ian Jackson
2014-03-21 13:52   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395239334-19579-2-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).